Rollup of 6 pull requests#155994
Closed
jhpratt wants to merge 15 commits intorust-lang:mainfrom
Closed
Conversation
As the FIXME comment says, these no longer use `ParseSess` and so the `parse` mod is not a good place for them. The `errors` mod is a better home.
Various places where `lift` just isn't necessary. Either because we're not within a closure passed to `tls::with`, or because the type being lifted doesn't have a `'tcx` lifetime.
Every lifting root calls `unwrap`/`expect` on the result, except for `ImmTy::fmt` but there's no good reason for that exception. Making lifting infallible is sensible because it should only fail if the wrong interner is somehow used, which indicates a major bug in rustc rather than an error condition.
Use `_mcount` as the mcount symbol name on RISC-V Linux GNU targets Fixes rust-lang#155830 glibc on RISC-V exports `_mcount`, not `mcount`. https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/riscv/machine-gmon.h;hb=HEAD r? mati865 (I think you're well-suited to review this area, but feel free to reroll)
…r=nikomatsakis Add feature gate for view_types experiment
…-arch, r=joshtriplett add `c_variadic_experimental_arch` feature tracking issue: rust-lang#155973 Based on https://hackmd.io/pIbUgMQuQcGaibJcinOcEw#Stabilize-c-variadic-function-definitions-rust155697, we'll gate niche targets where we don't control the implementation of `va_arg`, the ABI is unclear, or in general where we're not confident stabilizing the implementation.
…02, r=Kivooeo Reorganize `tests/ui/issues/` - 02 | old-name | new-sub-dir | new-name | |-|-|-| | `issue-19001.rs` [issue](rust-lang#19001) | `recursion/` | `recursive-struct-with-raw-pointer-field.rs` | | `issue-31769.rs` [issue](rust-lang#31769) | `attributes/` | `dont-allow-inline-and-repr-at-invalid-positions.rs` | | `issue-31769.stderr` | `attributes/` | `dont-allow-inline-and-repr-at-invalid-positions.stderr` | | `issue-33202.rs` [issue](rust-lang#33202) | `attributes/` | `repr-on-single-variant-Enum.rs` | | `issue-38763.rs` [issue](rust-lang#38763) | `foreign/` | `foreign-fn-with-more-than-8-byte-arg-size.rs` | r? Kivooeo
…TaKO8Ki Move `feature*` methods from `parse` mod to `errors` mod. As the FIXME comment says, these no longer use `ParseSess` and so the `parse` mod is not a good place for them. The `errors` mod is a better home. r? @TaKO8Ki
…oli-obk Make lifting infallible Details in individual commits. r? @oli-obk
rustbot
added
A-attributes
Member
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
⌛ Testing commit e4fabaa with merge d92e36c... Workflow: https://github.com/rust-lang/rust/actions/runs/25160935066 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 30, 2026
Rollup of 6 pull requests Successful merges: - #155853 (Use `_mcount` as the mcount symbol name on RISC-V Linux GNU targets) - #155939 (Add feature gate for view_types experiment) - #155974 (add `c_variadic_experimental_arch` feature) - #155523 (Reorganize `tests/ui/issues/` - 02) - #155980 (Move `feature*` methods from `parse` mod to `errors` mod.) - #155987 (Make lifting infallible) Failed merges: - #155237 (Disentangle AST crates and error crates)
Contributor
|
Stuck. Closing in favour of bigger rollup |
rust-bors
Bot
added
the
S-waiting-on-author
rust-bors
Bot
removed
the
S-waiting-on-bors
Contributor
|
This pull request was unapproved due to being closed. Auto build was cancelled due to the PR being closed. Cancelled workflows: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
_mcountas the mcount symbol name on RISC-V Linux GNU targets #155853 (Use_mcountas the mcount symbol name on RISC-V Linux GNU targets)c_variadic_experimental_archfeature #155974 (addc_variadic_experimental_archfeature)tests/ui/issues/- 02 #155523 (Reorganizetests/ui/issues/- 02)feature*methods fromparsemod toerrorsmod. #155980 (Movefeature*methods fromparsemod toerrorsmod.)Failed merges:
r? @ghost
Create a similar rollup