Check redundant_explicit_links against generated URLs#156009
Open
qaijuang wants to merge 1 commit intorust-lang:mainfrom
Open
Check redundant_explicit_links against generated URLs#156009qaijuang wants to merge 1 commit intorust-lang:mainfrom
redundant_explicit_links against generated URLs#156009qaijuang wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-author
qaijuang
changed the title
redundant_explicit_links against generated URLsredundant_explicit_links against generated URLs
Contributor
Author
This comment has been minimized.
This comment has been minimized.
qaijuang
force-pushed
the
rustdoc-redundant-explicit-links-url
branch
from
78cc7d7 to
52290d1
Compare
This comment has been minimized.
This comment has been minimized.
qaijuang
force-pushed
the
rustdoc-redundant-explicit-links-url
branch
from
52290d1 to
4c47005
Compare
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
r? @fmease rustbot has assigned @fmease. Use Why was this reviewer chosen?The reviewer was selected based on:
|
qaijuang
force-pushed
the
rustdoc-redundant-explicit-links-url
branch
from
4c47005 to
8a48cea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #155458.
rustdoc::redundant_explicit_linkschecked explicit link destinations by resolving both the label and the destination as intra-doc paths. That misses links written as local rustdoc page URLs, such asstruct.B.html, because those URLs do not appear indoc_link_resolutions.This PR keeps the existing path-resolution check and falls back to comparing the explicit destination with the local href rustdoc would generate for the resolved label. Fragmented URLs remain non-redundant, since removing the explicit target would change the destination.