Rollup of 7 pull requests#156190
Conversation
This reverts commit 5ad560f and adds a regression test.
resolve: Catch "cannot reexport" errors from macros 2.0 better After the macro 2.0 related holes are closed we can report `span_delayed_bug`s in more situations. Merging rust-lang#155945 would make changes in this PR simpler, but that PR will probably have to wait for quite some time. This is a continuation of my import & privacy invariant hardening changes from rust-lang#155257, rust-lang#155213, rust-lang#154149, etc. r? @mu001999
Print HRTB binders before fn qualifiers Fixes rust-lang#151393 This PR updates the custom fn-signature diff used in type mismatch diagnostics to print higher-ranked binders before fn qualifiers. We might want to update reference also: https://github.com/rust-lang/reference/blob/581920f9109f141b88b860b3e1e8359e3896a150/src/items/external-blocks.md?plain=1#L60
Implement a new flag `-Zdisable-fast-paths` in trait solving Discussion: [#t-types/trait-system-refactor > ask for help @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/364551-t-types.2Ftrait-system-refactor/topic/ask.20for.20help/near/583953725) r? lcnr
…henkov Revert "remove `MethodReceiverExpr` special-casing" This reverts commit 5ad560f and adds a regression test. Fixes rust-lang#156084. r? @petrochenkov
Revert const hacks and use const closures in std This revealed some smaller bugs in stability checking that I fixed where needed: * const closures use the const stability of their parent * trait method default bodies use the const stability of their trait Otherwise trivial reverts of the const hacks that were added fixes rust-lang#155781
Update `askama` version to `0.16.0` New features and bugfixes. Full changelog is [here](https://github.com/askama-rs/askama/releases/tag/v0.16.0). r? @Urgau
…r=mati865 Remove duplicate debug assert This is this.
|
💔 Test for 17beea4 failed: CI. Failed job:
|
|
@bors retry |
This comment has been minimized.
This comment has been minimized.
…uwer Rollup of 7 pull requests Successful merges: - #156014 (resolve: Catch "cannot reexport" errors from macros 2.0 better) - #156058 (Print HRTB binders before fn qualifiers) - #156172 (Implement a new flag `-Zdisable-fast-paths` in trait solving) - #156184 (Revert "remove `MethodReceiverExpr` special-casing") - #155957 (Revert const hacks and use const closures in std) - #156127 (Update `askama` version to `0.16.0`) - #156183 (Remove duplicate debug assert)
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test for ef76606 failed: CI. Failed job:
|
|
@bors retry |
This comment has been minimized.
This comment has been minimized.
|
📌 Perf builds for each rolled up PR:
previous master: 740679e1f5 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 740679e (parent) -> e95e732 (this PR) Test differencesShow 588 test diffsStage 1
Stage 2
Additionally, 586 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e95e73209faf6ead2bc5c7636e45e589a751b79b --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (e95e732): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Our benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.6%, secondary -1.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 1.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.0%, secondary -0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 495.494s -> 493.455s (-0.41%) |
Successful merges:
-Zdisable-fast-pathsin trait solving #156172 (Implement a new flag-Zdisable-fast-pathsin trait solving)MethodReceiverExprspecial-casing" #156184 (Revert "removeMethodReceiverExprspecial-casing")askamaversion to0.16.0#156127 (Updateaskamaversion to0.16.0)r? @ghost
Create a similar rollup