Rollup of 31 pull requests by jhpratt · Pull Request #157739 · rust-lang/rust

jhpratt · 2026-06-11T04:34:20Z

Successful merges:

Expand free alias types during variance computation #141030 (Expand free alias types during variance computation)
mgca: Register ConstArgHasType when normalizing projection consts #154853 (mgca: Register ConstArgHasType when normalizing projection consts)
Replace printables table with unicode_data.rs tables #155527 (Replace printables table with unicode_data.rs tables)
Stabilize core::range::{legacy, RangeFull, RangeTo} #156629 (Stabilize core::range::{legacy, RangeFull, RangeTo})
traits: Allow escaping self types in ExistentialTraitRef::with_self_ty #157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty)
Fix post-monomorphization error note race in the parallel frontend #157282 (Fix post-monomorphization error note race in the parallel frontend)
Make the retained dep graph deterministic under the parallel frontend #157352 (Make the retained dep graph deterministic under the parallel frontend)
Emit error for unused target expression in glob and list delegations #157601 (Emit error for unused target expression in glob and list delegations)
Update browser-ui-test version to 0.24.0 #157611 (Update browser-ui-test version to 0.24.0)
Add a strategy FnMut to inject behavior into the flush cycle #157620 (Add a strategy FnMut to inject behavior into the flush cycle)
Windows TLS - Only register the atexit hook when cleanup can be unloaded #157645 (Windows TLS - Only register the atexit hook when cleanup can be unloaded)
Keep rename-imported main alive in dead-code analysis under --test #157646 (Keep rename-imported main alive in dead-code analysis under --test)
Start using comptime for reflection intrinsics and their wrapper functions #157647 (Start using comptime for reflection intrinsics and their wrapper functions)
resolve: Partially revert "Remove a special case for dummy imports" #157719 (resolve: Partially revert "Remove a special case for dummy imports")
Ensure Send/Sync is not implemented for std::env::Vars{,Os} #155153 (Ensure Send/Sync is not implemented for std::env::Vars{,Os})
fix(mgca): Allow specifying generic args (of enum) on enum itself in unit & tuple variant constructions in (direct) const args #155198 (fix(mgca): Allow specifying generic args (of enum) on enum itself in unit & tuple variant constructions in (direct) const args)
refactor TypeRelativePath::AssocItem to use AliasTerm #155323 (refactor TypeRelativePath::AssocItem to use AliasTerm)
fix-155516: Don't suggest wrong unwrap expect #156497 (fix-155516: Don't suggest wrong unwrap expect)
Support defaults for static EIIs #156583 (Support defaults for static EIIs)
Ensure inferred let pattern types are well-formed #157013 (Ensure inferred let pattern types are well-formed)
Only suggest reborrowing a moved value where the reborrow is valid #157196 (Only suggest reborrowing a moved value where the reborrow is valid)
borrowck: avoid ICE describing fields on generic params #157230 (borrowck: avoid ICE describing fields on generic params)
platform support: add SNaN erratum to MIPS targets #157288 (platform support: add SNaN erratum to MIPS targets)
remove IsTypeConst from hir::TraitItemKind #157330 (remove IsTypeConst from hir::TraitItemKind)
compiletest: ignore SVG y offset in by-lines comparison #157350 (compiletest: ignore SVG y offset in by-lines comparison)
Add or_try_* variants for HashMap and BTreeMap Entry APIs #157355 (Add or_try_* variants for HashMap and BTreeMap Entry APIs)
Fix parser error recovery treating 'dyn' as a strict keyword in Rust 2015 when used in dyn + dyn #157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust 2015 when used in dyn + dyn)
Rename errors.rs file to diagnostics.rs (4/N) #157670 (Rename errors.rs file to diagnostics.rs (4/N))
Move symbol hiding code to a new file #157691 (Move symbol hiding code to a new file)
Rename errors.rs file to diagnostics.rs (5/N) #157700 (Rename errors.rs file to diagnostics.rs (5/N))
Fix doc link to Instant sub in saturating caveat #157703 (Fix doc link to Instant sub in saturating caveat)

Failed merges:

Arg splat experiment - hir FnDecl impl #157699 (Arg splat experiment - hir FnDecl impl)

On some platforms, it looks like these are not currently Send/Sync. We have a negative impl in env/common.rs. This is a breaking change on a bunch of targets, but it makes it less likely that someone unintentionally/accidentally depends on this. This is a potentially partial list but should be fairly complete: aarch64-unknown-none, aarch64-unknown-none-softfloat, armv7a-none-eabi, armv7a-none-eabihf, armv7r-none-eabi, armv7r-none-eabihf, armv8r-none-eabihf, loongarch64-unknown-none, loongarch64-unknown-none-softfloat, nvptx64-nvidia-cuda, riscv32i-unknown-none-elf, riscv32im-unknown-none-elf, riscv32imac-unknown-none-elf, riscv32imafc-unknown-none-elf, riscv32imc-unknown-none-elf, riscv64gc-unknown-none-elf, riscv64imac-unknown-none-elf, s390x-unknown-none-softfloat, thumbv6m-none-eabi, thumbv7a-none-eabi, thumbv7a-none-eabihf, thumbv7em-none-eabi, thumbv7em-none-eabihf, thumbv7m-none-eabi, thumbv7r-none-eabi, thumbv7r-none-eabihf, thumbv8m.base-none-eabi, thumbv8m.main-none-eabi, thumbv8m.main-none-eabihf, thumbv8r-none-eabihf, wasm32-unknown-unknown, wasm32v1-none, x86_64-unknown-none

When a `&mut`-typed value is moved out of a closure via a `for` loop's implicit `into_iter`, borrowck suggests "consider creating a fresh reborrow" (`&mut *place`) with `Applicability::MachineApplicable`. For a value captured by an `Fn` closure -- which holds its captures through `&self` -- that place cannot be borrowed mutably (E0596), so applying the machine-applicable suggestion produces code that does not compile. Gate the suggestion on borrowck's own `is_mutable` check for the reborrowed place, so it is only offered where `&mut *place` is valid: suppressed for `Fn`-closure captures, still offered for `FnMut` closures and ordinary `&mut` locals.

WF-checking walks through higher-ranked binders without instantiating them, so a `dyn Trait` nested inside a `for<'a>` bound reaches the `ty::Dynamic` arm of `WfPredicates::visit_ty` while still carrying escaping bound vars. Feeding that type into `ExistentialTraitRef::with_self_ty` violated its no-escaping-self precondition and tripped the assertion that guards it. The trait ref built there is only used to read off `ConstArgHasType` clauses, which constrain the trait's own const arguments and never mention the `Self` type. Substitute a fresh placeholder self type when the real one escapes: the assertion holds and the const-argument check is still performed. Re-enable the `with_self_ty` debug assertion now that its precondition is upheld.

One test covers the original ICE (a `dyn Trait` nested in a `for<'a>` bound, distilled from itertools). The other locks in that a const argument on such a nested `dyn` is still type-checked, so the placeholder-self-type fix cannot silently regress into dropping the `ConstArgHasType` check.

Doc typo

…on consts

…ction consts

…projection normalization

The in-memory dep graph kept for `-Zquery-dep-graph` is built by `GraphEncoder::record`, which pushed each node using `try_lock` and silently dropped the node when the lock was contended. Single-threaded the only contention is a query forced re-entrantly from within `with_retained_dep_graph`, so dropping was harmless. Under the parallel frontend several encoder threads record nodes at the same time, so a contended `try_lock` dropped nodes and edges at random, leaving the retained graph nondeterministic and making the dep-graph ui tests, which assert on its contents, fail intermittently. Remove that reentrancy in `check_paths`: read the graph into owned results while the lock is held, then emit the diagnostics afterwards. The only query forced inside the old closure was `def_path_str` (for the error messages), which can create dep nodes and re-enter the encoder; doing the emission after the lock is released means `record` never re-enters while the lock is held. `record` can then block on the lock unconditionally instead of using `try_lock`, so concurrent encoders never drop a node or edge. This only affects compilation with `-Zquery-dep-graph`; with the flag off the retained graph is absent and nothing changes.

These tests assert on the contents of the retained dep graph, which is now built deterministically under the parallel frontend, so they no longer need to be ignored there. Replace the ignore-parallel-frontend directives with blank lines rather than deleting them, so the following line numbers stay the same and the expected output is unchanged.

… checks

…to_term`

And rename a struct field.

This gets rid of the `printable.py` script, ensuring that `unicode-table-generator` handles all our Unicode data table generation needs. I've elected to give each Unicode property its own table, instead of merging them all into one. This is slightly less efficient in terms of space, but should allow us to expose these tables in the future with public methods on `char`.

These characters may be hidden/invisible otherwise.

rust-timer · 2026-06-11T12:03:57Z

Finished benchmarking commit (32cfe53): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.3%]	7
Regressions ❌ (secondary)	0.2%	[0.2%, 0.3%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	1
All ❌✅ (primary)	0.2%	[0.2%, 0.3%]	7

Max RSS (memory usage)

Results (primary -2.8%, secondary 1.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.3%	[1.0%, 2.3%]	4
Improvements ✅ (primary)	-2.8%	[-3.1%, -2.7%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.8%	[-3.1%, -2.7%]	3

Cycles

Results (primary 1.9%, secondary -3.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.9%, 1.9%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.9%	[-3.9%, -3.9%]	1
All ❌✅ (primary)	1.9%	[1.9%, 1.9%]	1

Binary size

Results (primary 0.1%, secondary 0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.0%, 0.6%]	19
Regressions ❌ (secondary)	0.5%	[0.4%, 0.6%]	42
Improvements ✅ (primary)	-0.4%	[-0.6%, -0.1%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-0.6%, 0.6%]	21

Bootstrap: 517.006s -> 518.719s (0.33%)
Artifact size: 401.43 MiB -> 401.39 MiB (-0.01%)

Rollup of 31 pull requests Successful merges: - rust-lang#141030 (Expand free alias types during variance computation) - rust-lang#154853 (mgca: Register `ConstArgHasType` when normalizing projection consts) - rust-lang#155527 (Replace printables table with `unicode_data.rs` tables) - rust-lang#156629 (Stabilize `core::range::{legacy, RangeFull, RangeTo}`) - rust-lang#157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty) - rust-lang#157282 (Fix post-monomorphization error note race in the parallel frontend) - rust-lang#157352 (Make the retained dep graph deterministic under the parallel frontend) - rust-lang#157601 (Emit error for unused target expression in glob and list delegations) - rust-lang#157611 (Update `browser-ui-test` version to `0.24.0`) - rust-lang#157620 (Add a strategy FnMut to inject behavior into the flush cycle) - rust-lang#157645 (Windows TLS - Only register the `atexit` hook when `cleanup` can be unloaded) - rust-lang#157646 (Keep rename-imported main alive in dead-code analysis under `--test`) - rust-lang#157647 (Start using comptime for reflection intrinsics and their wrapper functions) - rust-lang#157719 (resolve: Partially revert "Remove a special case for dummy imports") - rust-lang#155153 (Ensure Send/Sync is not implemented for std::env::Vars{,Os}) - rust-lang#155198 (fix(mgca): Allow specifying generic args (of enum) on enum itself in unit & tuple variant constructions in (direct) const args) - rust-lang#155323 (refactor `TypeRelativePath::AssocItem` to use `AliasTerm`) - rust-lang#156497 (fix-155516: Don't suggest wrong unwrap expect) - rust-lang#156583 (Support defaults for static EIIs) - rust-lang#157013 (Ensure inferred let pattern types are well-formed) - rust-lang#157196 (Only suggest reborrowing a moved value where the reborrow is valid) - rust-lang#157230 (borrowck: avoid ICE describing fields on generic params) - rust-lang#157288 (platform support: add SNaN erratum to MIPS targets) - rust-lang#157330 (remove `IsTypeConst` from `hir::TraitItemKind`) - rust-lang#157350 (compiletest: ignore SVG `y` offset in by-lines comparison) - rust-lang#157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs) - rust-lang#157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust 2015 when used in `dyn + dyn`) - rust-lang#157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N)) - rust-lang#157691 (Move symbol hiding code to a new file) - rust-lang#157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N)) - rust-lang#157703 (Fix doc link to Instant sub in saturating caveat) Failed merges: - rust-lang#157699 (Arg splat experiment - hir FnDecl impl)

JonathanBrouwer · 2026-06-13T10:54:19Z

Started perf runs

JonathanBrouwer · 2026-06-13T16:41:15Z

Regression in cargo caused by #155527, result is very small so we can probably ignore this.
Most of the other benchmarks seem to be noise, as they return to baseline the next run.
The only other regression that seems real is in bitmaps-3.2.1-new-solver

Mark-Simulacrum and others added 30 commits April 10, 2026 12:28

Ensure inferred let pattern types are well-formed

d780821

Don't suggest wrong unwrap expect

9633071

borrowck: avoid ICE describing fields on generic params

2314457

Add or_try_* variants for HashMap Entry API

de37dfd

Doc typo

platform support: add SNaN erratum to MIPS targets

92175ed

Register ConstArgHasType obligation when normalizing trait projecti…

a055c7c

…on consts

Register ConstArgHasType obligation when normalizing inherent proje…

7c52368

…ction consts

Add test that free type const value type mismatch does not ICE

d8cd4cc

Extract shared helper for registering ConstArgHasType during const …

1f9a514

…projection normalization

Register ConstArgHasType when normalizing free const aliases

1240be2

Use field-index fallback for undescribed fields

5a7ca04

Make instantiate_normalizes_to_term() also handle ConstArgHasType…

2e34f41

… checks

Register ConstArgHasType in queries

e8390d8

Attribute post-monomorphization error notes by emitting thread

c1cd236

Re-enable parallel frontend tests for post-monomorphization errors

2e128c7

Explain why we register ConstArgHasType in `instantiate_normalizes_…

e777ac3

…to_term`

Add type-const-free-value-used-in-body.rs regression test

fa11f19

Remove no longer needed #![expect(incomplete_features)]

277dccc

Update browser-ui-test version to 0.24.0

3ecbb39

Update nodejs version used in CI to 24.15.0

0d980a5

Improve core::char::mathods.rs docs

df53132

And rename a struct field.

char: move is_numeric next to is_alphanumeric

c15495f

Consider all Default_Ignorable_Code_Points unprintable

4db9ff5

These characters may be hidden/invisible otherwise.

rustbot added the perf-regression Performance regression. label Jun 11, 2026

jhpratt deleted the rollup-i0yIAZ9 branch June 11, 2026 19:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 31 pull requests#157739

Rollup of 31 pull requests#157739
rust-bors[bot] merged 90 commits into
rust-lang:mainfrom
jhpratt:rollup-i0yIAZ9

jhpratt commented Jun 11, 2026

Uh oh!

rust-timer commented Jun 11, 2026

Uh oh!

JonathanBrouwer commented Jun 13, 2026

Uh oh!

JonathanBrouwer commented Jun 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

jhpratt commented Jun 11, 2026

Uh oh!

rust-timer commented Jun 11, 2026

Overall result: ❌✅ regressions and improvements - please read:

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

JonathanBrouwer commented Jun 13, 2026

Uh oh!

JonathanBrouwer commented Jun 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants