run-make: handle AIX symbol cdylib export test#157989
Merged
Merged
Conversation
rustbot
added
A-run-make
Collaborator
|
r? @nnethercote rustbot has assigned @nnethercote. Use Why was this reviewer chosen?The reviewer was selected based on:
|
The cdylib export-symbols test was checking for `T my_function` on all non-Darwin targets, but AIX prints the exported symbol as `T .my_function`. This patch updates the test to account for the AIX behavior so the test validates the actual exported symbol correctly.
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
nnethercote
approved these changes
Jun 16, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 17, 2026
Rollup of 7 pull requests Successful merges: - #157681 (Add instrument_fn attribute) - #149219 (Allow shortening lifetime in CoerceUnsized for &mut) - #157539 (Rename `RandomSource` -> `Rng`, `DefaultRandomSource` -> `SystemRng`) - #157980 (Some minor cleanups around hir ty/pat/expr) - #157988 (Fix incremental-finalize-fail proc macro test on AIX) - #157989 (run-make: handle AIX symbol cdylib export test) - #157998 (Add big disclaimer to the description of lint `explicit_outlives_requirements`)
rust-timer
added a commit
that referenced
this pull request
Jun 17, 2026
Rollup merge of #157989 - amy-kwan:amy-kwan/cdylib-test, r=nnethercote run-make: handle AIX symbol cdylib export test The cdylib export-symbols test was checking for `T my_function` on all non-Darwin targets, but AIX prints the exported symbol as `T .my_function`. This patch updates the test to account for the AIX behavior so the test validates the actual exported symbol correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cdylib export-symbols test was checking for
T my_functionon all non-Darwin targets, but AIX prints the exported symbol asT .my_function.This patch updates the test to account for the AIX behavior so the test validates the actual exported symbol correctly.