perf: Eagerly convert literals to consts#68118
Merged
bors merged 4 commits intorust-lang:masterfrom Jan 15, 2020
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previousely even literal constants were being converted to an
Unevalutedconstant for evaluation later. This seems unecessary as no more information is needed to be able to convert the literal to a mir constant.Hopefully this will also minimise the performance impact of #67717, as far less constant evaluations are needed.