expand: Stop normalizing NtIdents before passing them to built-in macros#77275
Merged
bors merged 2 commits intorust-lang:masterfrom Sep 29, 2020
Merged
expand: Stop normalizing NtIdents before passing them to built-in macros#77275bors merged 2 commits intorust-lang:masterfrom
NtIdents before passing them to built-in macros#77275bors merged 2 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built-in macros should be able to deal with
NtIdentsin the input by themselves like any other parser code.You can't imagine how bad mutable AST visitors are, especially if they are modifying tokens.
This is one step towards removing token visiting from the visitor infrastructure (#77271 also works in this direction.)