Wrapper for -Z gcc-ld=lld to invoke rust-lld with the correct flavor#89288
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 8, 2021
Merged
Wrapper for -Z gcc-ld=lld to invoke rust-lld with the correct flavor#89288bors merged 1 commit intorust-lang:masterfrom
-Z gcc-ld=lld to invoke rust-lld with the correct flavor#89288bors merged 1 commit intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an
lld-wrappertool which is installed asldandld64inlib\rustlib\<host_target>\bin\gcc-lddirectory and whose sole purpose is to invokerust-lldin the parent directory with the correct flavor. Lld decides which flavor to use from either the first two commandline arguments or from the name of the executable (ldfor GNU/ld flavor,ld64for Darwin/Macos/ld64 flavor and so on). Symbolic links could not be used as they are not supported by rustup and on Windows.The wrapper replaces full copies of rust-lld which added some significant bloat. On UNIXish operating systems it exec rust-lld, on Windows it spawns it as a child process.
Fixes #88869.
r? @Mark-Simulacrum
cc @nagisa @petrochenkov @1000teslas