Modifications to std::io::Stdin on Windows so that there is no longer a 4-byte buffer minimum in read().#91754
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 4, 2022
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempted fix of issue #91722, where a too-small buffer was passed to the read function of stdio on Windows. This caused an error to be returned when
read_to_endorread_to_stringwere called. Both delegate tostd::io::default_read_to_end, which creates a buffer that is of length >0, and forwards it tostd::io::Stdin::read(). The latter method returns an error if the length of the buffer is less than 4, as there might not be enough space to allocate a UTF-16 character. This creates a problem when the buffer length is in0 < N < 4, causing the bug.The current modification creates an internal buffer, much like the one used for the write functions
I'd also like to acknowledge the help of @agausmann and @hkratz in detecting and isolating the bug, and for suggestions that made the fix possible.
Couple disclaimers:
or performance loss in benchmarks.The testing suite runs on my computer, and it does fix the issue noted in read_to_end / read_to_string returns Invalid Input ("buffer too small") on Windows MSVC #91722.Finally, this is my first pull request to the rust language, and as such some things may be weird/unidiomatic/plain out bad. If there are any obvious improvements I could do to the code, or any other suggestions, I would appreciate them.
Edit: Closes #91722