adapt native-link-modifier-bundle test no not emit LLVM bitcode#98424
Closed
krasimirgg wants to merge 2 commits intorust-lang:masterfrom
Closed
adapt native-link-modifier-bundle test no not emit LLVM bitcode#98424krasimirgg wants to merge 2 commits intorust-lang:masterfrom
krasimirgg wants to merge 2 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No functional changes intended.
This updates the test case to not embed LLVM bitcode.
This fixes a test failure over at the experimental build of rustc with HEAD LLVM:
https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/11144#01814d0f-a46a-4c19-91cf-41e720edb6f9/684-691.
The issue is that this test uses the system nm, which may not be recent
enough to understand the bitcode produced by rustc when compiled against HEAD LLVM.
Similar to what we did for another test in #94023. Note that we did another thing there, replaced nm with llvm-nm. I decided to not replace nm with llvm-nm here as that was a thing specifically changed in the original PR introducing this test: #95818 (comment).