impl std::error::Error for TryDemangleError#89
Open
GrigorenkoPV wants to merge 5 commits intorust-lang:mainfrom
Open
impl std::error::Error for TryDemangleError#89GrigorenkoPV wants to merge 5 commits intorust-lang:mainfrom
impl std::error::Error for TryDemangleError#89GrigorenkoPV wants to merge 5 commits intorust-lang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #61
I've also explicitly set edition in Cargo.toml manifests to 2015 to silence cargo warnings.
While we're at it, I've also run
cargo msrvbisection and found1.60to be the earliest version where this still builds.So I've set it explicitly in the manifests.
Sadly,
Errorgot intocoreonly in1.81.0, so I've usedstd::error::Errorinstead and gated the impl behindfeature = "std". Alternatively, we might consider bumping MSRV. I mean, it doesn't seem like supporting old Rust versions makes much sense for a library that parses Rust symbol mangling. Maybe it would even make sense to move this into the main monorepo? IDK.UPD:
native-c's build script needs 1.77 MSRV. bumped it for the crate.