Add let_chain_style configuration option#5983
Open
ytmimi wants to merge 1 commit intorust-lang:mainfrom
Open
Conversation
Now users have some control over how `let-chains` are formatted. The default value of `LegibleBindings` follows the style guide prescription defined in `r-l/rust 110568`. The `Tall` variant provides users an option to format all chain items on a single line if they fit.
|
This one would be really nice to have, as rustfmt currently explodes even the most trivial let chains into three lines unconditionally. |
jieyouxu
added
S-waiting-on-review
Collaborator
|
☔ The latest upstream changes (possibly #6823) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #5910, which added support for
let-chains.Now users have some control over how
let-chainsare formatted. The default value ofLegibleBindingsfollows the style guide prescription defined in r-l/rust#110568. TheTallvariant provides users an option to format all chain items on a single line if they fit.Happy to bike shed on the variant names, but I wanted to get the ball rolling on the new configuration.
r? @calebcartwright