Closed
Conversation
RalfJung
commented
Mar 10, 2026
| test_vec_2! { test_vec_max, vec_max, f32x4, f32x4 -> f32x4, | ||
| [1.0, f32::NAN, f32::INFINITY, 2.0], | ||
| [-10.0, -10.0, 5.0, f32::NAN], | ||
| [1.0, -10.0, f32::INFINITY, 2.0] |
Member
Author
There was a problem hiding this comment.
Actually I expect this to fail as the fallback does not handle NaNs correctly.
Member
Author
There was a problem hiding this comment.
Hm, strange. Tests pass with and without the enhancement target feature. Is the fallback actually more accurate than the docs say?
Member
Author
There was a problem hiding this comment.
Ah no, the test probably gets optimized away. (EDIT: Or maybe not, LLVM might just do a proper fallback that matches what it documents rather than the IBM docs.)
Still useful to have the test as it would have shown the issue with #2058.
Member
Author
|
We can just land this with #2058 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently no test actually covers instruction selection for vec_min / vec_max without the
vector-enhancements-1target feature.r? @folkertdev