A lot of cleanup in stdarch-gen-arm#2108
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
sayantn
force-pushed
the
cleanup-gen-arm
branch
4 times, most recently
from
fa2257c to
f4e9c59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simd_extractwithvget_lanematchsimd_shuffleThis helps with big-endian conversion -- only intrinsics that use
simd_extract,simd_insert,simd_shuffleor LLVM intrinsics needbig_endian_inverse, so this PR aims to push that number down as much as possible, so that it is easier to reason.I have split the
matchandsimd_shufflechanges into a lot of different commits because each one requires a different approach, totally different from thesimd_extractcase, where it is just replace withvget_laneeverywherer? @folkertdev
cc @davidtwco since you seemed interested
the last commit can be removed if #2110 is merged before this