Correct some wrong uses of LLVM intrinsics#2144
Open
sayantn wants to merge 2 commits into
Open
Conversation
Contributor
|
Out of curiosity, how did you find these? |
Contributor
Author
A modified version of rust-lang/rust#157145 |
folkertdev
reviewed
May 31, 2026
folkertdev
approved these changes
May 31, 2026
Member
|
wasm bits lgtm, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some small mistakes in the LLVM intrinsics, these were autoupgraded by LLVM so the builds passed. Also replaces all
extern "C"LLVM intrinsics blocks withextern "unadjusted"AArch64
cc @adamgemmell
neon.vluti4q.laneprefetchsve.{and,bic,eor,orr,orn}.z.xinsve.fcmla.laneandsve.frecpxsve.expa.xsve.fmmlasvcvtin two parts, because same size operands need a different intrinsicx86
prefetchNVPTX
I don't know who to cc here, the file was last modified by @gnzlbg but he doesn't seem active here anymore
llvm.nvvm.barrier0usedWASM32
cc @alexcrichton
llvm.wasm.memory.{grow,size}r? @folkertdev