Remove `DamageOutOfRange` error #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

madsmtm wants to merge 8 commits into master from madsmtm/remove-damage-out-of-range

Member

madsmtm commented Jan 19, 2026 •

edited

Loading

There is a very natural thing to do if we receive a damage rectangle outside supported bounds: Clamp it to be inside. This is also what's done by Wayland IIUC, and probably on other platforms as well, so let's do it in Softbuffer as well, and avoid the needless error case.

This also allows us to make present forward directly to present_with_damage, which is a nice internal simplification.

Finally, this exposed latent bugs with out-of-bounds damage regions on Windows, Web and X11, I've fixed those as well.

Tested on:

madsmtm added the enhancement label

madsmtm force-pushed the madsmtm/remove-damage-out-of-range branch 2 times, most recently from 551b385 to ab88d81 Compare

January 19, 2026 19:27

MarijnS95 reviewed

View reviewed changes

src/backends/wayland/mod.rs Outdated Show resolved Hide resolved

MarijnS95 reviewed

View reviewed changes

src/backends/android.rs Show resolved Hide resolved

MarijnS95 reviewed

View reviewed changes

src/backends/kms.rs Outdated Show resolved Hide resolved

MarijnS95 reviewed

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

MarijnS95 reviewed

View reviewed changes

src/backends/web.rs Outdated Show resolved Hide resolved

Member

MarijnS95 commented Jan 20, 2026

This is also what's done by Wayland IIUC

Maybe explicitly linking this portion of the documentation:

The compositor ignores the parts of the damage that fall outside of the surface.

madsmtm force-pushed the madsmtm/remove-damage-out-of-range branch from ab88d81 to 65b9295 Compare

January 20, 2026 19:33

madsmtm added 6 commits

January 20, 2026 20:51


          Remove DamageOutOfRange error

1c34cbd


          refactor: Remove internal present, keep only present_with_damage

6c68049


          fix(windows): Fix damage regions outside the pixel buffer

1ec2833


          fix(web): Fix damage regions outside the pixel buffer

ab16475


          fix(x11): Fix damage regions outside the pixel buffer

bc04c6e


          doc: Document ignored damage

55ce8e9

Damage that fall outside the surface is ignored.

madsmtm force-pushed the madsmtm/remove-damage-out-of-range branch from 65b9295 to 55ce8e9 Compare

January 20, 2026 19:51

madsmtm added 2 commits

January 21, 2026 15:57


          refactor: Add to_X_saturating helpers

c049f32

Makes it clearer what we're actually doing with the damage rectangles.


          refactor: Add clamp_rect utility

2d736ea

madsmtm force-pushed the madsmtm/remove-damage-out-of-range branch from eb25983 to 2d736ea Compare

January 21, 2026 14:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels