fix(helm): fix helm chart#141
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3270f71cf2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {{- if $leaderElect }} | ||
| args: | ||
| - --leader-elect={{ ternary "true" "false" $leaderElect }} | ||
| - --leader-elect |
There was a problem hiding this comment.
In the default chart path (operator.replicas: 1 with operator.leaderElect unset) and when users force operator.leaderElect=false, this conditional suppresses the entire args field. Kubernetes uses the image CMD when container args are absent, and this image declares CMD ["-h"] in Dockerfile:60; combined with the template's command: ["./operator", "server"], the pod runs ./operator server -h, prints help, and exits instead of starting the controller. Keep args present for the disabled case so the image CMD is not appended.
Useful? React with 👍 / 👎.
1 participant
Type of Change
Related Issues
Summary of Changes
Checklist
make pre-commit(fmt-check + clippy + test + console-lint + console-fmt-check)[Unreleased](if user-visible change)Impact
Verification
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.