Skip to content

Cash payouts auto funding#478

Merged
Sam Beveridge (00salmon) merged 42 commits intomasterfrom
cash-payouts-auto-funding
Feb 19, 2026
Merged

Cash payouts auto funding#478
Sam Beveridge (00salmon) merged 42 commits intomasterfrom
cash-payouts-auto-funding

Conversation

@zachharrison
Copy link
Contributor

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Links

  • Jira issue number: (PUT IT HERE)
  • Process.st launch checklist: (PUT IT HERE)

Checklists

Development

  • Prettier was run (if applicable)
  • The behaviour changes in the pull request are covered by specs
  • All tests related to the changed code pass in development

Paperwork

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has a Jira number
  • This pull request has a Process.st launch checklist

Code review

  • Changes have been reviewed by at least one other engineer
  • Security impacts of this change have been considered

Copilot AI review requested due to automatic review settings January 28, 2026 17:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements cash payout auto-funding functionality by introducing a new "PROCESSING" status for rewards and referrals that are awaiting scheduled payout. The changes update status handling logic, add new status display components, and reorganize story files to separate tax-and-cash-specific examples from general reward flows.

Changes:

  • Added PROCESSING status to handle rewards with scheduled future payouts
  • Updated status determination logic to check dateScheduled against current time
  • Created separate story files for tax-and-cash scenarios

Reviewed changes

Copilot reviewed 11 out of 13 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
packages/mint-components/src/components/sqm-stencilbook/sqm-stencilbook.tsx Added imports for new tax-and-cash story files and swapped import paths for existing stories
packages/mint-components/src/components/sqm-rewards-table/cells/sqm-rewards-table-status-cell.tsx Added PROCESSING status with date-based logic and updated status determination to check dateScheduled
packages/mint-components/src/components/sqm-rewards-table/cells/readme.md Updated documentation for new payoutProcessing prop and revised payoutApproved text
packages/mint-components/src/components/sqm-rewards-table/TaxAndCashRewardsTableCell.stories.tsx New story file demonstrating various tax-and-cash reward status cells
packages/mint-components/src/components/sqm-rewards-table/TaxAndCashRewardsTable.stories.tsx New story file showing complete tax-and-cash rewards table
packages/mint-components/src/components/sqm-rewards-table/RewardsTableCell.stories.tsx Removed tax-related status exports and added cash reward data
packages/mint-components/src/components/sqm-rewards-table/RewardsTable.stories.tsx Removed tax-and-cash-specific story rows
packages/mint-components/src/components/sqm-referral-table/cells/sqm-referral-table-rewards-cell.tsx Added PROCESSING status with similar date-based logic and updated status text templates
packages/mint-components/src/components/sqm-referral-table/TaxAndCashReferralTableRewardsCell.stories.tsx New story file for tax-and-cash referral table reward cells
packages/mint-components/src/components/sqm-referral-table/TaxAndCashReferralTable.stories.tsx New story file for complete tax-and-cash referral table
packages/mint-components/package.json Version bump to 2.0.10-0
Files not reviewed (1)
  • packages/mint-components/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…s/sqm-rewards-table-status-cell.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 30, 2026 18:43
…s/sqm-rewards-table-status-cell.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ls/sqm-referral-table-rewards-cell.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ls/sqm-referral-table-rewards-cell.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 13 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • packages/mint-components/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 6, 2026 00:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 14 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • packages/mint-components/package-lock.json: Language not supported
Comments suppressed due to low confidence (2)

packages/mint-components/src/components/sqm-referral-table/cells/sqm-referral-table-rewards-cell.tsx:1

  • Corrected spelling from 'based your' to 'based on your' (appears twice in the PAYOUT_APPROVED and PROCESSING messages).
import { Component, h, Prop } from "@stencil/core";

packages/mint-components/src/components/sqm-referral-table/cells/sqm-referral-table-rewards-cell.tsx:1

  • Inconsistent variable usage - the condition uses partnerFundsStatus in some checks and partnerTransferStatus in others, but these reference the same value. Use the same variable name throughout for consistency.
import { Component, h, Prop } from "@stencil/core";

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 11, 2026 00:26
Copilot AI review requested due to automatic review settings February 18, 2026 18:13
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Noah Clarke (noahwc) and others added 2 commits February 18, 2026 10:16
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 22 out of 24 changed files in this pull request and generated 7 comments.

Files not reviewed (1)
  • packages/mint-components/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 18, 2026 22:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 25 changed files in this pull request and generated 6 comments.

Files not reviewed (1)
  • packages/mint-components/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 19, 2026 00:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 31 out of 33 changed files in this pull request and generated 12 comments.

Files not reviewed (1)
  • packages/mint-components/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…t-status-alert/usePayoutStatus.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 19, 2026 18:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 31 out of 33 changed files in this pull request and generated 3 comments.

Files not reviewed (1)
  • packages/mint-components/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

},
{
date: DateTime.fromMillis(
this.reward.partnerFundsTransfer.dateScheduled,
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For defensive programming, consider adding optional chaining when accessing this.reward.partnerFundsTransfer.dateScheduled. While the code logic ensures this is only called when PROCESSING status is set (which requires partnerFundsTransfer to exist), adding optional chaining (this.reward.partnerFundsTransfer?.dateScheduled) would make the code more robust and consistent with the similar code in sqm-referral-table-rewards-cell.tsx line 277.

Suggested change
this.reward.partnerFundsTransfer.dateScheduled,
this.reward.partnerFundsTransfer?.dateScheduled,

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@00salmon Sam Beveridge (00salmon) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@00salmon Sam Beveridge (00salmon) merged commit 707cf76 into master Feb 19, 2026
17 of 20 checks passed
@00salmon Sam Beveridge (00salmon) deleted the cash-payouts-auto-funding branch February 19, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments