Skip to content

fix(W-22515355): update global type - #904

Merged
soridalac merged 1 commit into
mainfrom
k80/global-type-fix
Aug 21, 2026
Merged

fix(W-22515355): update global type#904
soridalac merged 1 commit into
mainfrom
k80/global-type-fix

Conversation

@k80bowman

Copy link
Copy Markdown
Contributor

What does this PR do?

Updates telemetryGlobal.ts to use typeof globalThis instead of NodeJs.Global, which was deprecated in Node v6 and has since been removed. This had not caused problems before because @types/mocha replicated it, but with the upcoming switch to TypeScript v6 it is causing failures because TypeScript v6 now only loads types that are reachable from the compiled files, instead of loading all types declarations regardless.

What issues does this PR fix or reference?

@W-22515355@

@soridalac
soridalac merged commit a67b9da into main Aug 21, 2026
14 checks passed
@soridalac
soridalac deleted the k80/global-type-fix branch August 21, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants