Skip to content

Improvement/arsn 577 delimiter max listing fix#2620

Merged
bert-e merged 2 commits intodevelopment/8.4from
improvement/ARSN-577-delimiter-maxListing-fix
Apr 30, 2026
Merged

Improvement/arsn 577 delimiter max listing fix#2620
bert-e merged 2 commits intodevelopment/8.4from
improvement/ARSN-577-delimiter-maxListing-fix

Conversation

@benzekrimaha
Copy link
Copy Markdown
Contributor

@benzekrimaha benzekrimaha commented Apr 22, 2026

Issue: ARSN-577

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 22, 2026

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

This commit updates the expected limit for the delimiterCurrent
algorithm when the bucket format is v0. In v0 versioned buckets,
the listing algorithm iterates over both master and version keys interleaved,
which means that the limit needs to be multiplied by 2 to ensure that enough master keys
are included in the listing results.
This change ensures that the delimiterCurrent algorithm correctly accounts for
the presence of version keys in v0 buckets and provides accurate results when a maxScannedLifecycleListingEntries
limit is set.
Tests were also updated to reflect this change in expected behavior.
Issue: ARSN-577
@benzekrimaha benzekrimaha force-pushed the improvement/ARSN-577-delimiter-maxListing-fix branch from 3e745dc to 1600790 Compare April 22, 2026 10:48
@scality scality deleted a comment from bert-e Apr 22, 2026
@benzekrimaha benzekrimaha requested review from a team, SylvainSenechal and delthas April 22, 2026 10:50
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 22, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.48%. Comparing base (06da567) to head (2dbcf1b).
⚠️ Report is 7 commits behind head on development/8.4.

Additional details and impacted files
@@               Coverage Diff                @@
##           development/8.4    #2620   +/-   ##
================================================
  Coverage            73.48%   73.48%           
================================================
  Files                  222      222           
  Lines                18183    18184    +1     
  Branches              3787     3788    +1     
================================================
+ Hits                 13361    13362    +1     
  Misses                4817     4817           
  Partials                 5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benzekrimaha benzekrimaha marked this pull request as ready for review April 22, 2026 13:18
@benzekrimaha
Copy link
Copy Markdown
Contributor Author

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 30, 2026

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.4

The following branches will NOT be impacted:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.1
  • development/8.2
  • development/8.3

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 30, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.4

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.1
  • development/8.2
  • development/8.3

Please check the status of the associated issue ARSN-577.

Goodbye benzekrimaha.

@bert-e bert-e merged commit 6b3b58b into development/8.4 Apr 30, 2026
8 checks passed
@bert-e bert-e deleted the improvement/ARSN-577-delimiter-maxListing-fix branch April 30, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants