CLDSRV-895: ListParts return part checksum#6160
CLDSRV-895: ListParts return part checksum#6160leif-scality wants to merge 3 commits intodevelopment/9.4from
Conversation
leif-scality
commented
Apr 23, 2026
- Return part checksum in ListParts
b9b6b70 to
3f5975c
Compare
e70ef55 to
0d730f5
Compare
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 1 file with indirect coverage changes @@ Coverage Diff @@
## development/9.4 #6160 +/- ##
===================================================
+ Coverage 84.97% 85.04% +0.07%
===================================================
Files 207 207
Lines 13760 13778 +18
===================================================
+ Hits 11692 11718 +26
+ Misses 2068 2060 -8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
b7f26b1 to
ba4d20e
Compare
|
3f5975c to
e38fc58
Compare
ba4d20e to
0eda67c
Compare
|
Hello leif-scality,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
0eda67c to
6267253
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
|
LGTM |
| } | ||
|
|
||
| function getPartChecksumXML(checksumAlgorithm, checksumValue) { | ||
| if (!checksumAlgorithm || checksumValue === undefined) { |
There was a problem hiding this comment.
| if (!checksumAlgorithm || checksumValue === undefined) { | |
| if (!checksumAlgorithm || !checksumValue) { |
?
| const partChecksumXML = mpuOverviewObj.checksumIsDefault ? | ||
| undefined : getPartChecksumXML( |
There was a problem hiding this comment.
Should we also check if (mpuOverviewObj.checksumAlgorithm && mpuOverviewObj.checksumType) ?