Skip to content

CLDSRV-895: ListParts return part checksum#6160

Open
leif-scality wants to merge 3 commits intodevelopment/9.4from
improvement/CLDSRV-895-list-parts-return-checksum
Open

CLDSRV-895: ListParts return part checksum#6160
leif-scality wants to merge 3 commits intodevelopment/9.4from
improvement/CLDSRV-895-list-parts-return-checksum

Conversation

@leif-scality
Copy link
Copy Markdown
Contributor

  • Return part checksum in ListParts

@leif-scality leif-scality force-pushed the improvement/CLDSRV-892-store-checksum-in-part-shadow-object branch from b9b6b70 to 3f5975c Compare April 23, 2026 10:30
@leif-scality leif-scality force-pushed the improvement/CLDSRV-895-list-parts-return-checksum branch from e70ef55 to 0d730f5 Compare April 23, 2026 10:31
Comment thread package.json Outdated
@claude
Copy link
Copy Markdown

claude Bot commented Apr 23, 2026

  • Arsenal dependency is pinned to a feature branch instead of a version tag — must be updated to a tag (e.g. 8.3.11) before merge for reproducible builds.

    Review by Claude Code

Comment thread package.json Outdated
@claude
Copy link
Copy Markdown

claude Bot commented Apr 23, 2026

  • Arsenal dependency is pinned to a branch (improvement/ARSN-575-forward-part-checksum-for-list-parts) instead of a tag
    - Pin to a released tag (e.g. 8.3.11) before merging

    Review by Claude Code

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.04%. Comparing base (fc49fd1) to head (6267253).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/api/listParts.js 95.45% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/services.js 87.43% <ø> (ø)
lib/api/listParts.js 92.30% <95.45%> (+2.40%) ⬆️

... and 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.4    #6160      +/-   ##
===================================================
+ Coverage            84.97%   85.04%   +0.07%     
===================================================
  Files                  207      207              
  Lines                13760    13778      +18     
===================================================
+ Hits                 11692    11718      +26     
+ Misses                2068     2060       -8     
Flag Coverage Δ
file-ft-tests 68.78% <86.36%> (+0.02%) ⬆️
kmip-ft-tests 28.08% <4.54%> (-0.03%) ⬇️
mongo-v0-ft-tests 69.98% <86.36%> (+0.06%) ⬆️
mongo-v1-ft-tests 69.94% <86.36%> (+0.01%) ⬆️
multiple-backend 36.35% <4.54%> (-0.05%) ⬇️
sur-tests 35.39% <4.54%> (-0.97%) ⬇️
sur-tests-inflights 37.30% <4.54%> (-0.08%) ⬇️
unit 71.51% <95.45%> (+0.05%) ⬆️
utapi-v2-tests 34.66% <4.54%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread package.json Outdated
Comment thread tests/functional/aws-node-sdk/test/object/mpuUploadPartChecksum.js Outdated
@claude
Copy link
Copy Markdown

claude Bot commented Apr 23, 2026

  • Arsenal dependency is pinned to a branch (improvement/ARSN-575-forward-part-checksum-for-list-parts) instead of a tag. Git-based deps must pin to a tag for reproducible builds.
    - Pin to the released tag (e.g. 8.3.11) before merging.
    - Variable shadowing in mpuUploadPartChecksum.js: const part = listRes.Parts.find(part => ...) shadows the outer part.
    - Rename the callback parameter to avoid shadowing.

    Review by Claude Code

@leif-scality leif-scality force-pushed the improvement/CLDSRV-895-list-parts-return-checksum branch from b7f26b1 to ba4d20e Compare April 23, 2026 10:48
Comment thread package.json Outdated
@claude
Copy link
Copy Markdown

claude Bot commented Apr 23, 2026

  • Arsenal dependency is pinned to a feature branch instead of a release tag. Pin to tag 8.3.11 (or the appropriate release) before merging.
    - Update package.json and regenerate yarn.lock with the tagged version.

    Review by Claude Code

Comment thread lib/api/listParts.js Outdated
@leif-scality leif-scality force-pushed the improvement/CLDSRV-892-store-checksum-in-part-shadow-object branch from 3f5975c to e38fc58 Compare April 24, 2026 08:46
@leif-scality leif-scality force-pushed the improvement/CLDSRV-895-list-parts-return-checksum branch from ba4d20e to 0eda67c Compare April 24, 2026 09:34
Comment thread package.json Outdated
@claude
Copy link
Copy Markdown

claude Bot commented Apr 24, 2026

  • Arsenal dependency is pinned to a branch instead of a release tag. Pin to a versioned tag (e.g. 8.3.11) before merging for reproducible builds.

    Review by Claude Code

Base automatically changed from improvement/CLDSRV-892-store-checksum-in-part-shadow-object to development/9.4 April 24, 2026 12:46
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 24, 2026

Hello leif-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 24, 2026

Incorrect fix version

The Fix Version/s in issue CLDSRV-895 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.4.0

Please check the Fix Version/s of CLDSRV-895, or the target
branch of this pull request.

@leif-scality leif-scality force-pushed the improvement/CLDSRV-895-list-parts-return-checksum branch from 0eda67c to 6267253 Compare April 24, 2026 14:00
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 24, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@claude
Copy link
Copy Markdown

claude Bot commented Apr 24, 2026

LGTM

Review by Claude Code

Comment thread lib/api/listParts.js
}

function getPartChecksumXML(checksumAlgorithm, checksumValue) {
if (!checksumAlgorithm || checksumValue === undefined) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!checksumAlgorithm || checksumValue === undefined) {
if (!checksumAlgorithm || !checksumValue) {

?

Comment thread lib/api/listParts.js
Comment on lines +308 to +309
const partChecksumXML = mpuOverviewObj.checksumIsDefault ?
undefined : getPartChecksumXML(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also check if (mpuOverviewObj.checksumAlgorithm && mpuOverviewObj.checksumType) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants