Skip to content

impr(CLDSRV-869): Fix buckets refilled calculation#6162

Merged
tmacro merged 1 commit intoimprovement/CLDSRV-869/account_limitingfrom
improvement/CLDSRV-869/fix_refill_logging
Apr 28, 2026
Merged

impr(CLDSRV-869): Fix buckets refilled calculation#6162
tmacro merged 1 commit intoimprovement/CLDSRV-869/account_limitingfrom
improvement/CLDSRV-869/fix_refill_logging

Conversation

@tmacro
Copy link
Copy Markdown
Contributor

@tmacro tmacro commented Apr 27, 2026

Previously a bucket would be counted as "refilled" every time after the first refill.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.30%. Comparing base (39751a9) to head (a842dd2).
⚠️ Report is 2 commits behind head on improvement/CLDSRV-869/account_limiting.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/api/apiUtils/rateLimit/tokenBucket.js 50.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/api/apiUtils/rateLimit/refillJob.js 89.47% <100.00%> (ø)
lib/api/apiUtils/rateLimit/tokenBucket.js 82.89% <50.00%> (-1.11%) ⬇️

... and 2 files with indirect coverage changes

@@                             Coverage Diff                             @@
##           improvement/CLDSRV-869/account_limiting    #6162      +/-   ##
===========================================================================
+ Coverage                                    84.22%   84.30%   +0.07%     
===========================================================================
  Files                                          204      204              
  Lines                                        13107    13108       +1     
===========================================================================
+ Hits                                         11040    11051      +11     
+ Misses                                        2067     2057      -10     
Flag Coverage Δ
file-ft-tests 68.04% <37.50%> (+0.04%) ⬆️
kmip-ft-tests 28.47% <0.00%> (-0.01%) ⬇️
mongo-v0-ft-tests 69.23% <37.50%> (+<0.01%) ⬆️
mongo-v1-ft-tests 69.22% <37.50%> (-0.04%) ⬇️
multiple-backend 35.60% <0.00%> (-0.01%) ⬇️
sur-tests 36.13% <0.00%> (+0.02%) ⬆️
sur-tests-inflights 37.99% <0.00%> (-0.01%) ⬇️
unit 69.65% <62.50%> (-0.01%) ⬇️
utapi-v2-tests 34.81% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tmacro tmacro force-pushed the improvement/CLDSRV-869/fix_refill_logging branch from 157ef70 to a842dd2 Compare April 28, 2026 17:34
@tmacro tmacro merged commit 951a9d8 into improvement/CLDSRV-869/account_limiting Apr 28, 2026
28 of 29 checks passed
@tmacro tmacro deleted the improvement/CLDSRV-869/fix_refill_logging branch April 28, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants