compute_extrema function over domain for a UFL expression#187
Merged
Conversation
Member
Author
|
Resolves #186 |
finsberg
reviewed
Feb 22, 2026
Comment on lines
+160
to
+192
| def eval_J(x_ref): | ||
| if isinstance(u, dolfinx.fem.Function): | ||
| _x_p[: mesh.geometry.dim] = mesh.geometry.cmap.push_forward( | ||
| x_ref.reshape(-1, mesh.topology.dim), mesh_nodes | ||
| )[0] | ||
| try: | ||
| u_eval = u.eval(_x_p, _cell)[0] | ||
| except RuntimeError: # NOTE: Nonlinear pullback might fail on low precision | ||
| u_expr = dolfinx.fem.Expression( | ||
| u, | ||
| x_ref, | ||
| comm=MPI.COMM_SELF, | ||
| jit_options=jit_options, | ||
| dtype=mesh.geometry.x.dtype, | ||
| ) | ||
| u_eval = u_expr.eval(mesh, _cell)[0][0] | ||
| else: | ||
| u_expr = dolfinx.fem.Expression( | ||
| u, x_ref, comm=MPI.COMM_SELF, jit_options=jit_options, dtype=mesh.geometry.x.dtype | ||
| ) | ||
| u_eval = u_expr.eval(mesh, _cell)[0][0] | ||
| return np.float64(sign * u_eval) # SLSQP only supports float64 | ||
|
|
||
| def eval_dJ(x_ref): | ||
| u_grad_expr = dolfinx.fem.Expression( | ||
| ufl.Jacobian(mesh).T * ufl.grad(u), | ||
| x_ref, | ||
| comm=MPI.COMM_SELF, | ||
| jit_options=jit_options, | ||
| dtype=mesh.geometry.x.dtype, | ||
| ) | ||
| u_grad_eval = u_grad_expr.eval(mesh, _cell)[0][0] | ||
| return (sign * u_grad_eval).astype(np.float64) # SLSQP only supports float64 |
Member
There was a problem hiding this comment.
I wonder it is would be more clean to put these to methods as instance methods on a class instead. The class could potentially be useful in other contexts.
Member
Author
There was a problem hiding this comment.
Not sure... We can talk about this tomorrow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it possible to compute the min or max of a scalar valued ufl expression over a domain.