Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
该 PR 主要优化选项页「日志(Logger)」的展示信息与排版:将时间范围与日志统计信息拆分并重新格式化,同时补充/调整相关多语言文案键值以匹配新的 UI 结构。
Changes:
- 调整 Logger 页头部摘要的展示结构与样式(时间范围 + 统计信息分段显示)
- 新增通用的句子分隔符 i18n key,并为多语言补充
to等新文案 - 更新部分语言下
now的翻译以匹配新的展示语义
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/options/routes/Logger.tsx | 重构日志摘要行的 UI(时间范围样式化、统计信息用分隔符拼接、List 上边距调整) |
| src/locales/en-US/translation.json | 新增 sentence-separator、新增 to |
| src/locales/de-DE/translation.json | 新增 sentence-separator、新增 to |
| src/locales/ru-RU/translation.json | 新增 sentence-separator、新增 to |
| src/locales/vi-VN/translation.json | 新增 sentence-separator、新增 to |
| src/locales/zh-CN/translation.json | 新增 sentence-separator、新增 to、调整 now |
| src/locales/zh-TW/translation.json | 新增 sentence-separator、新增 to、调整 now |
| src/locales/ja-JP/translation.json | 新增 sentence-separator、新增 to、调整 now |
| src/locales/ach-UG/translation.json | 新增 to |
Comment on lines
+350
to
+357
| color: "var(--color-text-4)", | ||
| }} | ||
| > | ||
| {" -- "} | ||
| </Typography.Text> | ||
| <Typography.Text | ||
| style={{ | ||
| color: "var(--color-text-1)", |
| > | ||
| {formatUnixTime(startTime)} | ||
| {t("to")} | ||
| {isNow ? `${formatUnixTime(endTime)} (${t("now")})` : formatUnixTime(endTime)} |
| "clear_completed": "crwdns8082:0crwdne8082:0", | ||
| "clear_logs": "crwdns8084:0crwdne8084:0", | ||
| "to": " - ", | ||
| "now": "Now", |
Member
Code reviewFound 2 issues:
scriptcat/src/pages/options/routes/Logger.tsx Lines 336 to 367 in d94851f
scriptcat/src/pages/options/routes/Logger.tsx Lines 348 to 355 in d94851f 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
按 CLAUDE.md 约定,避免使用内联 style,改用 tw- 前缀工具类。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After