Skip to content

Conversation

@odyssey2122
Copy link

A summary of your pull request, including the what change you're making and why.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Security Review

Please ensure sensitive data is properly protected in your integration.

  • Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

@joe-ayoub-segment
Copy link
Contributor

Thanks for the PR @odyssey2122 I'll schedule for review.

@joe-ayoub-segment
Copy link
Contributor

Looks like this is just a scaffold - when you've completed the PR and would like a review please ping me.

@odyssey2122
Copy link
Author

odyssey2122 commented Dec 18, 2025 via email

@joe-ayoub-segment
Copy link
Contributor

Hi @odyssey2122 are you sure you pushed your most recent changes? I don't see 2 Actions, and there's no implementation code in the perform() function.

@joe-ayoub-segment joe-ayoub-segment mentioned this pull request Dec 19, 2025
6 tasks
@odyssey2122
Copy link
Author

odyssey2122 commented Dec 19, 2025

Hello @joe-ayoub-segment you were right. Thank you for your patience and for pointing out the issues with the missing actions and implementation logic.

We have identified the root cause of the empty perform() functions and missing actions. It appears that while the implementation was complete locally, a set of commits had not been correctly pushed to the remote branch, and the destination was missing its registration in the main entry point.

Changes implemented in the latest push:

Destination Registration: Officially registered the collab-travel-crm destination in the root index.ts of the destination-actions package.
Action Implementations: Confirmed and pushed the full implementation for both trackEvent and identifyUser actions. The perform() functions now contain the correct logic for syncing data with the Collab Travel CRM API.
Verification: We have verified the implementation with 31 unit tests covering authentication, event mapping, and data structures, all of which are passing.

The collab-travel-crm branch is now up to date with the complete implementation. Please let us know if you need any further information to proceed with the approval.

Best regards,
Stephen

@joe-ayoub-segment joe-ayoub-segment changed the title Segment Actions and code [Collab Travel CRM] - New Destination Dec 21, 2025
@joe-ayoub-segment
Copy link
Contributor

Hi @odyssey2122 thanks for the PR.
I reviewed it, then fixed a couple of minor things and push the changes to your remote branch.
The code is ready to deploy.
We won't be doing a deployment until early January though as we're in a code freeze.

I'll notify you once it is live.

Best regards,
Joe

register('6909cac9d608c9ad592d7211', './aws-kinesis')
register('690de842dc73c4bb198a38e6', './tiktok-app-events')
register('6937efdfdf772b67ee7174c5', './zapier')
register('64f703d1f6e9aa0a283ae3e4', './collab-travel-crm')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @odyssey2122 - please remove this. The value here is something I'll add when I register the integration.

@odyssey2122
Copy link
Author

odyssey2122 commented Dec 21, 2025 via email

@joe-ayoub-segment
Copy link
Contributor

Note to self: unit tests pass locally. yarn types are updated. unclear why CI failing. Will check again prior to deploy in Jan

@joe-ayoub-segment
Copy link
Contributor

Moved this to an internal PR so I could fix linting issue #3502

@joe-ayoub-segment
Copy link
Contributor

Hi @odyssey2122 can you please send me an email to [email protected] please? I need your email address so I can add you to the partner portal.

@odyssey2122
Copy link
Author

odyssey2122 commented Jan 6, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants