-
Notifications
You must be signed in to change notification settings - Fork 297
[Collab Travel CRM] - New Destination #3486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR @odyssey2122 I'll schedule for review. |
|
Looks like this is just a scaffold - when you've completed the PR and would like a review please ping me. |
|
Hi Joe, the destination is now complete and ready for review. It includes
two actions (trackEvent, identifyUser) with full test coverage. The catalog
documentation PR is also submitted to segment-docs. Thanks!
…On Thu, Dec 18, 2025 at 5:53 AM Joe Ayoub ***@***.***> wrote:
*joe-ayoub-segment* left a comment (segmentio/action-destinations#3486)
<#3486 (comment)>
Looks like this is just a scaffold - when you've completed the PR and
would like a review please ping me.
—
Reply to this email directly, view it on GitHub
<#3486 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXJU3AKAMCOZLRJYL5MVRA34CKIVNAVCNFSM6AAAAACPKDAIVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNRZHEZDEMRXG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi @odyssey2122 are you sure you pushed your most recent changes? I don't see 2 Actions, and there's no implementation code in the perform() function. |
|
Hello @joe-ayoub-segment you were right. Thank you for your patience and for pointing out the issues with the missing actions and implementation logic. We have identified the root cause of the empty perform() functions and missing actions. It appears that while the implementation was complete locally, a set of commits had not been correctly pushed to the remote branch, and the destination was missing its registration in the main entry point. Changes implemented in the latest push: Destination Registration: Officially registered the collab-travel-crm destination in the root index.ts of the destination-actions package. The collab-travel-crm branch is now up to date with the complete implementation. Please let us know if you need any further information to proceed with the approval. Best regards, |
|
Hi @odyssey2122 thanks for the PR. I'll notify you once it is live. Best regards, |
| register('6909cac9d608c9ad592d7211', './aws-kinesis') | ||
| register('690de842dc73c4bb198a38e6', './tiktok-app-events') | ||
| register('6937efdfdf772b67ee7174c5', './zapier') | ||
| register('64f703d1f6e9aa0a283ae3e4', './collab-travel-crm') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @odyssey2122 - please remove this. The value here is something I'll add when I register the integration.
|
Thank you Joe, We appreciate your support.
Have a great holiday.
Regards,
Stephen
Stephen Scott
CEO, Luxury Travel Advisor
Travel Hub 365 Inc.
209 W Jackson Blvd. Suite 300
Chicago IL. 60606
312-940-7386 (direct)
***@***.***
travelhub365.com / odysseytravelapp.com
Travel Weekly 2024 Magellan Award Winner
Luxury Travel Advisor Magazine – Trendsetter
Black Travel Advisory Board Co-Chair – Northstar Travel Group
…On Sun, Dec 21, 2025 at 9:33 AM Joe Ayoub ***@***.***> wrote:
*joe-ayoub-segment* left a comment (segmentio/action-destinations#3486)
<#3486 (comment)>
Hi @odyssey2122 <https://github.com/odyssey2122> thanks for the PR.
I reviewed it, then fixed a couple of minor things and push the changes to
your remote branch.
The code is ready to deploy.
We won't be doing a deployment until early January though as we're in a
code freeze.
I'll notify you once it is live.
Best regards,
Joe
—
Reply to this email directly, view it on GitHub
<#3486 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXJU3ANHROJJMWCES4UXEAD4C24WNAVCNFSM6AAAAACPKDAIVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNZYHEYDINZWGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Note to self: unit tests pass locally. yarn types are updated. unclear why CI failing. Will check again prior to deploy in Jan |
|
Moved this to an internal PR so I could fix linting issue #3502 |
|
Hi @odyssey2122 can you please send me an email to [email protected] please? I need your email address so I can add you to the partner portal. |
|
Yes, email sent from ***@***.*** from my iPhoneOn Jan 6, 2026, at 2:50 AM, Joe Ayoub ***@***.***> wrote:joe-ayoub-segment left a comment (segmentio/action-destinations#3486)
Hi @odyssey2122 can you please send me an email to ***@***.*** please? I need your email address so I can add you to the partner portal.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
A summary of your pull request, including the what change you're making and why.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'