fixed missing files in installation#508
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue with missing files during package installation by adjusting the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an issue with missing files in the installation by updating pyproject.toml to use automatic package discovery. My review points out that this change introduces redundancy with the existing setup.py file. I've suggested removing the duplicated configuration from setup.py to align with modern Python packaging standards and improve overall maintainability.
fddd555 to
11807e0
Compare
Motivation
Some users have reported that the script will raise import errors like
sglang.core.eagle3 not foundafter doingpip install. This is because of thepyproject..tomlconfig.Modifications
findinpyproject.toml.setup.pyto avoid duplicationRelated Issues
Accuracy Test
Benchmark & Profiling
Checklist