Skip to content

fixed missing files in installation#508

Merged
FrankLeeeee merged 1 commit intosgl-project:mainfrom
FrankLeeeee:hotfix/installation
Mar 24, 2026
Merged

fixed missing files in installation#508
FrankLeeeee merged 1 commit intosgl-project:mainfrom
FrankLeeeee:hotfix/installation

Conversation

@FrankLeeeee
Copy link
Copy Markdown
Collaborator

@FrankLeeeee FrankLeeeee commented Mar 20, 2026

Motivation

Some users have reported that the script will raise import errors like sglang.core.eagle3 not found after doing pip install. This is because of the pyproject..toml config.

Modifications

  1. Use find in pyproject.toml.
  2. Removed setup.py to avoid duplication

Related Issues

Accuracy Test

Benchmark & Profiling

Checklist

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue with missing files during package installation by adjusting the pyproject.toml configuration. The changes switch from an explicit package listing to a more dynamic package discovery method, which includes necessary source files while excluding non-essential directories like configurations, scripts, and tests.

Highlights

  • Installation Configuration: Modified pyproject.toml to refine package discovery during installation, ensuring correct file inclusion and exclusion of development-related directories.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes an issue with missing files in the installation by updating pyproject.toml to use automatic package discovery. My review points out that this change introduces redundancy with the existing setup.py file. I've suggested removing the duplicated configuration from setup.py to align with modern Python packaging standards and improve overall maintainability.

@FrankLeeeee FrankLeeeee force-pushed the hotfix/installation branch from fddd555 to 11807e0 Compare March 24, 2026 04:13
@FrankLeeeee FrankLeeeee merged commit 88baa2f into sgl-project:main Mar 24, 2026
2 checks passed
@FrankLeeeee FrankLeeeee deleted the hotfix/installation branch March 24, 2026 04:34
Supemovaa pushed a commit to Supemovaa/SpecForge that referenced this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant