Skip to content

Commit ec86894

Browse files
committed
Fix Rubocop issues in Pro dummy spec
1 parent 2999433 commit ec86894

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

react_on_rails_pro/spec/dummy/spec/prepare_node_renderer_bundles_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
require "rails_helper"
44

5-
describe ReactOnRailsPro::PrepareNodeRenderBundles do # rubocop:disable RSpec/FilePath
5+
describe ReactOnRailsPro::PrepareNodeRenderBundles do # rubocop:disable RSpec/FilePath,RSpec/SpecFilePathFormat
66
let(:asset_filename) { "loadable-stats2.json" }
77
let(:asset_filename2) { "loadable-stats3.json" }
88
let(:fixture_path) { File.expand_path("./spec/fixtures/#{asset_filename}") }

react_on_rails_pro/spec/dummy/spec/rails_helper.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,11 +126,11 @@
126126
Rack::Handler::Puma.run(app, Port: port)
127127
end
128128

129-
config.before(:each, type: :system, js: true) do
129+
config.before(:each, :js, type: :system) do
130130
driven_by driver
131131
end
132132

133-
config.before(:each, type: :system, rack_test: true) do
133+
config.before(:each, :rack_test, type: :system) do
134134
driven_by :rack_test
135135
end
136136

react_on_rails_pro/spec/dummy/spec/system/integration_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,7 @@ def change_text_expect_dom_selector(dom_selector, expect_no_change: false)
432432
"#ServerComponentRouter-react-component-0"
433433

434434
# Skip the test that fails without JavaScript - being addressed in another PR
435-
it "renders the page completely on server and displays content on client even without JavaScript", # rubocop:disable RSpec/NoExpectationExample
435+
it "renders the page completely on server and displays content on client even without JavaScript",
436436
skip: "Being addressed in another PR" do
437437
# This test is overridden to skip it
438438
end

0 commit comments

Comments
 (0)