Skip to content

Fix broken pnpm lock file for dummy apps #2201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbanoubGhadban merged 11 commits into from
Dec 11, 2025
Merged

Fix broken pnpm lock file for dummy apps #2201

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
44eab4c
make dummy apps work as separate packages outside the workspace
AbanoubGhadban Dec 10, 2025
600145a
remove --ignore-workspace argument from pnpm install
AbanoubGhadban Dec 10, 2025
0d4f858
update root pnpm file
AbanoubGhadban Dec 10, 2025
eb77fe1
update pnpm lock files
AbanoubGhadban Dec 10, 2025
2c00d63
revert this: update gems cache keys
AbanoubGhadban Dec 10, 2025
db2bd13
make pnpm-workspace files not include any packages
AbanoubGhadban Dec 10, 2025
5ad2608
fix precompile-check "yalc add" command
AbanoubGhadban Dec 10, 2025
9d3adda
Revert "revert this: update gems cache keys"
AbanoubGhadban Dec 10, 2025
6603cb1
remove "--ignore-workspace" option from pnpm install commands at spec…
AbanoubGhadban Dec 10, 2025
c2f6200
remove pwd debugging statement
AbanoubGhadban Dec 10, 2025
8c1a060
tiny changes at CI and workspace setup
AbanoubGhadban Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,8 @@ jobs:
# Use --link to maintain the link: protocol that matches pnpm-lock.yaml
run: cd react_on_rails/spec/dummy && yalc add --link react-on-rails
- name: Install Node modules with pnpm for dummy app
# --ignore-workspace prevents pnpm from treating this as part of the parent workspace
# minimum config changes package.json (shakapacker version), so can't use frozen lockfile
run: cd react_on_rails/spec/dummy && pnpm install --ignore-workspace ${{ matrix.dependency-level == 'minimum' && '--no-frozen-lockfile' || '' }}
run: cd react_on_rails/spec/dummy && pnpm install ${{ matrix.dependency-level == 'minimum' && '--no-frozen-lockfile' || '' }}
- name: Save dummy app ruby gems to cache
uses: actions/cache@v4
with:
Expand Down Expand Up @@ -260,9 +259,8 @@ jobs:
# Use --link to maintain the link: protocol that matches pnpm-lock.yaml
run: cd react_on_rails/spec/dummy && yalc add --link react-on-rails
- name: Install Node modules with pnpm for dummy app
# --ignore-workspace prevents pnpm from treating this as part of the parent workspace
# minimum config changes package.json (shakapacker version), so can't use frozen lockfile
run: cd react_on_rails/spec/dummy && pnpm install --ignore-workspace ${{ matrix.dependency-level == 'minimum' && '--no-frozen-lockfile' || '' }}
run: cd react_on_rails/spec/dummy && pnpm install ${{ matrix.dependency-level == 'minimum' && '--no-frozen-lockfile' || '' }}
- name: Dummy JS tests
run: |
cd react_on_rails/spec/dummy
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/lint-js-and-ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,7 @@ jobs:
# Use --link to maintain the link: protocol that matches pnpm-lock.yaml
run: cd react_on_rails/spec/dummy && yalc add --link react-on-rails
- name: Install Node modules with pnpm for dummy app
# --ignore-workspace prevents pnpm from treating this as part of the parent workspace
# The dummy app has its own dependencies and uses yalc links
run: cd react_on_rails/spec/dummy && pnpm install --ignore-workspace
run: cd react_on_rails/spec/dummy && pnpm install

- name: Install Ruby Gems for package
run: cd react_on_rails && bundle check --path=vendor/bundle || bundle _2.5.9_ install --path=vendor/bundle --jobs=4 --retry=3
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/playwright.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,9 @@ jobs:

- name: Install dummy app dependencies
working-directory: react_on_rails/spec/dummy
# --ignore-workspace prevents pnpm from treating this as part of the parent workspace
run: |
bundle install
pnpm install --ignore-workspace
pnpm install

- name: Install Playwright browsers
working-directory: react_on_rails/spec/dummy
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/precompile-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,9 @@ jobs:
- name: yalc publish for react-on-rails
run: cd packages/react-on-rails && yalc publish
- name: yalc add react-on-rails
run: cd react_on_rails/spec/dummy && yalc add react-on-rails
run: cd react_on_rails/spec/dummy && yalc add --link react-on-rails
- name: Install Node modules with pnpm for dummy app
# --ignore-workspace prevents pnpm from treating this as part of the parent workspace
# The dummy app doesn't have a pnpm-lock.yaml
run: cd react_on_rails/spec/dummy && pnpm install --ignore-workspace
run: cd react_on_rails/spec/dummy && pnpm install
- name: Save dummy app ruby gems to cache
uses: actions/cache@v4
with:
Expand Down
13 changes: 4 additions & 9 deletions .github/workflows/pro-integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,8 @@ jobs:
pnpm install --frozen-lockfile

- name: Install Node modules with pnpm for Pro dummy app
# --ignore-workspace prevents pnpm from treating this as part of the parent workspace
# The Pro dummy app has its own dependencies and uses yalc links
run: cd spec/dummy && pnpm install --ignore-workspace
run: |
cd spec/dummy && pnpm install

- name: Install Ruby Gems for Pro dummy app
run: |
Expand Down Expand Up @@ -266,9 +265,7 @@ jobs:
pnpm install --frozen-lockfile

- name: Install Node modules with pnpm for Pro dummy app
# --ignore-workspace prevents pnpm from treating this as part of the parent workspace
# The Pro dummy app has its own dependencies and uses yalc links
run: cd spec/dummy && pnpm install --ignore-workspace
run: cd spec/dummy && pnpm install

- name: Ensure minimum required Chrome version
run: |
Expand Down Expand Up @@ -468,9 +465,7 @@ jobs:
pnpm install --frozen-lockfile

- name: Install Node modules with pnpm for Pro dummy app
# --ignore-workspace prevents pnpm from treating this as part of the parent workspace
# The Pro dummy app has its own dependencies and uses yalc links
run: cd spec/dummy && pnpm install --ignore-workspace
run: cd spec/dummy && pnpm install

- name: Ensure minimum required Chrome version
run: |
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/pro-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,12 +154,10 @@ jobs:
bundle _2.5.4_ check || bundle _2.5.4_ install --jobs=4 --retry=3

- name: Install Node modules with pnpm for Pro dummy app
# --ignore-workspace prevents pnpm from treating this as part of the parent workspace
run: cd spec/dummy && pnpm install --ignore-workspace
run: cd spec/dummy && pnpm install

- name: Install Node modules with pnpm for ExecJS dummy app
# --ignore-workspace prevents pnpm from treating this as part of the parent workspace
run: cd spec/execjs-compatible-dummy && pnpm install --ignore-workspace
run: cd spec/execjs-compatible-dummy && pnpm install

- name: Generate file-system based entrypoints
run: cd spec/dummy && bundle exec rake react_on_rails:generate_packs
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/pro-test-package-and-gem.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,7 @@ jobs:
pnpm install --frozen-lockfile

- name: Install Node modules with pnpm for Pro dummy app
# --ignore-workspace prevents pnpm from treating this as part of the parent workspace
run: cd spec/dummy && pnpm install --ignore-workspace
run: cd spec/dummy && pnpm install

- name: Install Ruby Gems for Pro dummy app
run: |
Expand Down
Loading
Loading