pkg: fix GetLastError function that was returned always nil#2273
Merged
gustavosbarreto merged 1 commit intomasterfrom Nov 25, 2022
Merged
pkg: fix GetLastError function that was returned always nil#2273gustavosbarreto merged 1 commit intomasterfrom
gustavosbarreto merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/reviewcommand toshellhub-io/adminteam members. Non-admin users get a reply explaining they're not authorized and how to request a review through the admin team.authorized == 'true'instead of!= 'false'so unexpected errors (API failures, missing output) deny access rather than granting it.env:blocks instead of inline${{ }}interpolation. Also fixes a pre-existinggithub.head_refinjection in the branch detection step.::warning::annotations for unexpected responses instead of silently treating all failures as unauthorized.Prerequisite
The GitHub App (
CLOUD_DISPATCH_APP_ID/shellhub-ci-dispatch) must have Organization > Members: Read permission for the team membership check. Configure at: https://github.com/organizations/shellhub-io/settings/apps/shellhub-ci-dispatchTest plan
/reviewon a PR with no issues — verify the bot posts a "no issues found" closing comment/review— verify the review runs normally with eyes reaction/review— verify they get the unauthorized reply, no eyes reaction, and no review runs/review— verify a::warning::annotation appears and access is denied