Open
Conversation
added 2 commits
April 28, 2014 12:58
Owner
|
Thanks. I'm trying to add Travis-CI integration to the project so I can run the tests on different PHP environments. Unfortunately the tests are currently failing (not only on your branch, on all of them). I have very little time to invest in this. Eventually I'll merge things, it may just take a while. If you want to help with getting the tests to run properly on Travis-CI, I'd appreciate any help. I've created a branch captolia/php55-compat which contains some work for that (includes your PR too). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After upgrading to PHP 5.5 I got a 'Bus Error 10' when including the module.
Allocating the jsonreader_prop_handlers HashTable solved this problem.