Skip to content

SG-42549 Change git configuration to use LFS#338

Draft
julien-lang wants to merge 2 commits intomasterfrom
ticket/SG-42549-use-git-lfs--no-rebuild
Draft

SG-42549 Change git configuration to use LFS#338
julien-lang wants to merge 2 commits intomasterfrom
ticket/SG-42549-use-git-lfs--no-rebuild

Conversation

@julien-lang
Copy link
Member

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR switches the vendored Python source dependency bundles (resources/python/src/<version>/pkgs.zip) to be stored via Git LFS, reducing repository bloat from large binary artifacts.

Changes:

  • Add a root .gitattributes rule to track resources/python/src/*/pkgs.zip with Git LFS.
  • Replace per-version pkgs.zip files (3.7, 3.9, 3.10, 3.11, 3.13) with Git LFS pointer files.

Reviewed changes

Copilot reviewed 1 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.gitattributes Adds Git LFS tracking rule for resources/python/src/*/pkgs.zip.
resources/python/src/3.7/pkgs.zip Converted to Git LFS pointer.
resources/python/src/3.9/pkgs.zip Converted to Git LFS pointer.
resources/python/src/3.10/pkgs.zip Converted to Git LFS pointer.
resources/python/src/3.11/pkgs.zip Converted to Git LFS pointer.
resources/python/src/3.13/pkgs.zip Converted to Git LFS pointer.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -0,0 +1 @@
resources/python/src/*/pkgs.zip filter=lfs diff=lfs merge=lfs -text
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding filter=lfs for resources/python/src/*/pkgs.zip makes correct builds/packaging dependent on Git LFS being installed and enabled during checkout and when regenerating/pushing these zips (e.g., Azure Pipelines and any release packaging that uses git archive/GitHub source zips). Without an explicit LFS fetch/checkout step, consumers may receive the pointer text file instead of the real zip, which will then fail at runtime when pkgs.zip is added to sys.path. Please ensure CI/deploy tooling enables LFS (e.g., checkout: self with LFS enabled or running git lfs install + git lfs pull) and that the release packaging process bundles LFS objects, not pointers.

Suggested change
resources/python/src/*/pkgs.zip filter=lfs diff=lfs merge=lfs -text
resources/python/src/*/pkgs.zip -text

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants