fix(typeahead): keep overlay position fixed when scrolling#1640
Draft
fix(typeahead): keep overlay position fixed when scrolling#1640
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where the typeahead overlay would not maintain its position when the page is scrolled. The fix involves adding scrollStrategy: this.overlay.scrollStrategies.reposition() to the overlay configuration. This is the correct approach to ensure the overlay repositions itself relative to the input element during scroll events. The change is concise and effectively resolves the bug.
Member
Author
|
Optimally need to find a way to test this behaviour. |
spliffone
reviewed
Mar 13, 2026
Member
There was a problem hiding this comment.
I am in favour of having the scroll strategy configurable, since we might need a different behaviour in filtered search oder other use cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://material.angular.dev/cdk/overlay/overview#scroll-strategies, fixes #1588
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: