Skip to content

fix(typeahead): keep overlay position fixed when scrolling#1640

Draft
ljanner wants to merge 1 commit intomainfrom
fix/typeahead-overlay-position
Draft

fix(typeahead): keep overlay position fixed when scrolling#1640
ljanner wants to merge 1 commit intomainfrom
fix/typeahead-overlay-position

Conversation

@ljanner
Copy link
Member

@ljanner ljanner commented Mar 13, 2026

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue where the typeahead overlay would not maintain its position when the page is scrolled. The fix involves adding scrollStrategy: this.overlay.scrollStrategies.reposition() to the overlay configuration. This is the correct approach to ensure the overlay repositions itself relative to the input element during scroll events. The change is concise and effectively resolves the bug.

@ljanner
Copy link
Member Author

ljanner commented Mar 13, 2026

Optimally need to find a way to test this behaviour.

@ljanner ljanner self-assigned this Mar 13, 2026
@ljanner ljanner added this to the 49.x milestone Mar 13, 2026
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favour of having the scroll strategy configurable, since we might need a different behaviour in filtered search oder other use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typeahead overlay position is fixed

2 participants