Skip to content

Add support for per-chapter remarks#934

Open
pmachapman wants to merge 1 commit intomainfrom
per_chapter_remarks
Open

Add support for per-chapter remarks#934
pmachapman wants to merge 1 commit intomainfrom
per_chapter_remarks

Conversation

@pmachapman
Copy link
Copy Markdown
Collaborator

@pmachapman pmachapman commented Apr 29, 2026

Fixes #905.

Requires sillsdev/machine#408.


This change is Reviewable

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.97872% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.27%. Comparing base (97ef312) to head (c6be0c7).

Files with missing lines Patch % Lines
...rval.Translation/Services/UsfmGenerationService.cs 82.97% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
- Coverage   66.30%   66.27%   -0.04%     
==========================================
  Files         371      371              
  Lines       21559    21539      -20     
  Branches     2743     2744       +1     
==========================================
- Hits        14294    14274      -20     
- Misses       6257     6258       +1     
+ Partials     1008     1007       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pmachapman pmachapman requested review from Enkidu93 and ddaspit April 30, 2026 04:43
Copy link
Copy Markdown
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add remarks per chapter

3 participants