Reject synchronous batch callback failures - #16
Closed
simPod wants to merge 2 commits into
Closed
Conversation
simPod
force-pushed
the
fix/throwable-values
branch
from
August 18, 2026 06:36
b77d6db to
f06ce5e
Compare
simPod
force-pushed
the
fix/synchronous-batch-throw
branch
from
August 18, 2026 07:41
edbfcd6 to
795227f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
A callback that threw before returning a promise escaped dispatch and could leave queued promises unresolved or cache a failed immediate load. The current
masterThrowable contract now handles bothExceptionandErrorconsistently.