cleanup docker compose based branch deployment#649
Open
boddumanohar wants to merge 1 commit intodevfrom
Open
Conversation
boddumanohar
force-pushed
the
cleanup-compose-based-branch
branch
from
f76f4cd to
bf485d5
Compare
boddumanohar
requested review from
mxsrc and
noctarius
and removed request for
mxsrc
Member
Author
|
just found there are 10 branches with image tag as 15.1.0.147' |
boddumanohar
force-pushed
the
cleanup-compose-based-branch
branch
from
bf485d5 to
6375b5c
Compare
Member
Author
|
I think its safe to having this. Because we have currently already blocked the new VMs from creating with 15.1.0.147 tag. Changes that are touched as a part of this PR only affects the branch creation logic. Once the branches are already created, the VM lifecycle flows (Stop, Start, resize) never touch this parts. That's why even for existing VM this wouldn't break anything. |
mxsrc
reviewed
Mar 8, 2026
| - name: config | ||
| mountPath: "/vela/config" | ||
| configMap: | ||
| name: {{ include "vela.autoscaler.composeConfigName" . }} |
Collaborator
There was a problem hiding this comment.
Is there a way to rename this as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We also don't support them as such VMs start is quite slow.