fix(storage): support Azure connection string for presigned URLs#2997
Merged
waleedlatif1 merged 5 commits intostagingfrom Jan 25, 2026
Merged
fix(storage): support Azure connection string for presigned URLs#2997waleedlatif1 merged 5 commits intostagingfrom
waleedlatif1 merged 5 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryThis PR fixes Azure Blob Storage presigned URL generation when using connection strings and adds embedding dimension optimization. The core bug fix properly parses Azure connection strings to extract credentials needed for SAS token generation, resolving failures when only Key Changes:
Critical Issue:
Confidence Score: 2/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant App as Application
participant Client as BlobClient
participant Parser as parseConnectionString()
participant Getter as getAccountCredentials()
participant Azure as Azure Blob Storage
Note over App,Azure: Presigned URL Generation Flow
App->>Client: getPresignedUrl(key, expiresIn)
Client->>Getter: getAccountCredentials()
alt Connection String Available
Getter->>Parser: parseConnectionString(connectionString)
Parser->>Parser: Extract AccountName via regex
Parser->>Parser: Extract AccountKey via regex
Parser-->>Getter: {accountName, accountKey}
else Account Name/Key Available
Getter-->>Getter: Return {accountName, accountKey}
end
Getter-->>Client: credentials
Client->>Client: Create StorageSharedKeyCredential
Client->>Client: Generate SAS token with credentials
Client->>Azure: Sign URL with SAS token
Azure-->>Client: Presigned URL
Client-->>App: Presigned URL
Note over App,Azure: Embedding Generation with Custom Dimensions
App->>Client: generateEmbeddings(texts, model)
Client->>Client: supportsCustomDimensions(modelName)
alt Model supports dimensions (embedding-3)
Client->>Azure: Request with dimensions: 1536
else Model doesn't support
Client->>Azure: Request without dimensions
end
Azure-->>Client: Embeddings
Client-->>App: Embeddings array
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AZURE_CONNECTION_STRINGwas setType of Change
Testing
Tested manually
Checklist