fix(docs): separate local and blob asset resolution for quick-reference#3007
Merged
waleedlatif1 merged 2 commits intostagingfrom Jan 26, 2026
Merged
fix(docs): separate local and blob asset resolution for quick-reference#3007waleedlatif1 merged 2 commits intostagingfrom
waleedlatif1 merged 2 commits intostagingfrom
Conversation
ActionImage now uses local paths directly for PNGs while ActionVideo uses blob storage with proper path normalization (strips static/ prefix). Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile OverviewGreptile SummaryThis PR fixes 404 errors by separating asset resolution paths for images and videos in the quick-reference documentation. PNG images now load directly from the local Key Changes:
Observations:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant MDX as Quick Reference MDX
participant AI as ActionImage Component
participant AV as ActionVideo Component
participant NBP as normalizeBlobPath
participant GAU as getAssetUrl
participant Static as /static/ Directory
participant Blob as Vercel Blob Storage
Note over MDX: PNG Image Request
MDX->>AI: src="/static/quick-reference/image.png"
AI->>AI: Ensure leading slash
AI->>Static: /static/quick-reference/image.png
Static-->>MDX: PNG served locally
Note over MDX: MP4 Video Request
MDX->>AV: src="/static/quick-reference/video.mp4"
AV->>NBP: "/static/quick-reference/video.mp4"
NBP->>NBP: Strip leading "/"
NBP->>NBP: Strip "static/" prefix
NBP-->>AV: "quick-reference/video.mp4"
AV->>GAU: "quick-reference/video.mp4"
alt CDN Configured
GAU-->>AV: ${CDN}/quick-reference/video.mp4
else No CDN
GAU-->>AV: /quick-reference/video.mp4
end
AV->>Blob: Request video from blob storage
Blob-->>MDX: MP4 streamed
|
…ctly Remove path normalization logic from action-media component. Instead, use the appropriate paths in MDX: - PNGs: /static/quick-reference/... (local) - MP4s: quick-reference/... (blob via getAssetUrl)
9a1dfb8 to
b04f8ca
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/static/)static/prefixTest plan
/static/quick-reference/path