Skip to content

Cisco Pipeline#661

Merged
abaranov25 merged 18 commits intosintel-dev:masterfrom
abaranov25:cisco
Mar 2, 2026
Merged

Cisco Pipeline#661
abaranov25 merged 18 commits intosintel-dev:masterfrom
abaranov25:cisco

Conversation

@abaranov25
Copy link
Collaborator

@abaranov25 abaranov25 commented Feb 17, 2026

Resolve #663
Adding a Cisco pipeline to Orion

@CLAassistant
Copy link

CLAassistant commented Feb 17, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ abaranov25
❌ AllenBaranov


AllenBaranov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sarahmish sarahmish self-requested a review February 22, 2026 00:26
Comment on lines +18 to +19
"window_size": 30720,
"step_size": 16
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to have these values similar to the other pipelines, i.e.

Suggested change
"window_size": 30720,
"step_size": 16
"window_size": 250,
"step_size": 1

Is there a reason for this value?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. 30720 fine samples are required to fully populate the coarse context for cisco. With an aggregation factor of 60 and 512 coarse points, we need 512*60=30720 points. We could use 250 points by default, but there would only be 4 long term context points, all of which are reflected in the fine context. It would turn the model into (basically) a timesfm clone.

Comment on lines +25 to +26
"window_size": 250,
"window_step_size": 40
Copy link
Collaborator

@sarahmish sarahmish Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if window_size and window_step_size are specified, then you can remove window_size_portion and window_step_size_portion

Comment on lines +142 to +143
series: 1D numpy array
agg_factor: Aggregation factor (default 60 = minute->hour)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is series a raw forecast? 1D array of what exactly?

Suggested change
series: 1D numpy array
agg_factor: Aggregation factor (default 60 = minute->hour)
series (ndarray):
1D numpy array
agg_factor (int):
Aggregation factor (default 60 = minute->hour)

agg_factor: Aggregation factor (default 60 = minute->hour)

Returns:
coarse, coarse_mask, fine, fine_mask
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be described instead of returning variable names

abaranov25 and others added 6 commits February 23, 2026 03:32
Co-authored-by: Sarah Alnegheimish <40212131+sarahmish@users.noreply.github.com>
Co-authored-by: Sarah Alnegheimish <40212131+sarahmish@users.noreply.github.com>
Co-authored-by: Sarah Alnegheimish <40212131+sarahmish@users.noreply.github.com>
Co-authored-by: Sarah Alnegheimish <40212131+sarahmish@users.noreply.github.com>
Co-authored-by: Sarah Alnegheimish <40212131+sarahmish@users.noreply.github.com>
@abaranov25 abaranov25 merged commit 7bd8140 into sintel-dev:master Mar 2, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cisco TSFM Pipeline

3 participants