Skip to content

Don't restart DTLS after receiving new tls-id while passive #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexbakker wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −2
Open

Don't restart DTLS after receiving new tls-id while passive #2157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions daemon/call.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2228,8 +2228,13 @@ static void __dtls_logic(const sdp_ng_flags *flags,
}
else if (other_media->tls_id.len && (sp->tls_id.len == 0 || str_cmp_str(&other_media->tls_id, &sp->tls_id))) {
// previously seen tls-id and new tls-id is different or not present
ilogs(crypto, LOG_INFO, "TLS-ID changed, restarting DTLS");
__dtls_restart(other_media);
if (MEDIA_ISSET(other_media, SETUP_PASSIVE) && !MEDIA_ISSET(other_media, SETUP_ACTIVE)) {
// passive: active peer controls DTLS restart
ilogs(crypto, LOG_INFO, "TLS-ID changed, passive role, not restarting DTLS");
} else {
ilogs(crypto, LOG_INFO, "TLS-ID changed, restarting DTLS");
__dtls_restart(other_media);
}
}
else if (ice_is_restart(other_media->ice_agent, sp) && !other_media->tls_id.len && !sp->tls_id.len) {
// Skip DTLS restart if no-tls-id flag is active (user opted out of TLS-ID handling)
Expand Down
Loading