Add virtualenv package to dependencies list #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfinus
force-pushed
the
missing_virtualenv_dependency
branch
from
d2fe9ca to
d72d049
Compare
dolfinus
commented
May 13, 2021
| def _virtualenv(self): | ||
| """The arguments used to call virtualenv.""" | ||
|
|
||
| return [sys.executable, '-m', 'virtualenv'] |
Author
There was a problem hiding this comment.
Because now we can be sure that virtualenv is installed into the same environment as the current package, we can call it directly. Otherwise it is possible to receive some strange caused by wrong PATH value or too old virtualenv package.
dolfinus
commented
May 13, 2021
| return os.path.split(self.path)[0] | ||
|
|
||
| @property | ||
| def name(self): |
Author
There was a problem hiding this comment.
virtualenv can handle absolute path of a target directory, let's use it instead of relative one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
This package is directly calling
virtualenvexecutable. But it could be not installed in the current environment. Especially in case of Python 3 there it was replaced with new system packagevenv.My proposal is to all
virtualenvpackage to a list of dependencies instead of adding some checks if package is present or not. Alsovirtualenvis already falling back tovenvin case of Python 3, so there is no need to perform such a check manually.