Conversation
### Description <img width="2518" height="1014" alt="image" src="https://github.com/user-attachments/assets/efb4a8c6-bce4-425f-ba15-e3b746cfa3de" /> 현재 Course 탭에서 강좌 회색처리를 위한 종료 시점 판단이 Spring/Summer/Fall/Winter 별로 4등분하고있습니다. Spring의 경우 5월 이후 종료처리가 되고 있어 각 학기별 종료 시점을 다음과 같이 임의로 설정했습니다. Spring: 6월 / Summer: 7월 / Fall: 12월 / Winter: 1월 TODO : 강좌 종료일을 받아 강좌 별로 종료일에 맞춰 비활성화 처리하는 로직이 필요할 것 같습니다. ### Additional context <!-- e.g. is there anything you'd like reviewers to focus on? --> --- ### Before submitting the PR, please make sure you do the following - [ ] Read the [Contributing Guidelines](https://github.com/skkuding/next/blob/main/CONTRIBUTING.md) - [ ] Read the [Contributing Guidelines](https://github.com/skkuding/next/blob/main/CONTRIBUTING.md#pr-and-branch) and follow the [Commit Convention](https://github.com/skkuding/next/blob/main/CONTRIBUTING.md#commit-convention) - [ ] Provide a description in this PR that addresses **what** the PR is solving, or reference the issue that it solves (e.g. `fixes #123`). - [ ] Ideally, include relevant tests that fail without this PR but pass with it.
### Description 현재 표절검사 결과를 받아오는 과정에서 가장 최신 요청을 가장 오래된 요청을 잘못 받아오고 있어 해당 부분을 수정합니다. ### Additional context <!-- e.g. is there anything you'd like reviewers to focus on? --> --- ### Before submitting the PR, please make sure you do the following - [ ] Read the [Contributing Guidelines](https://github.com/skkuding/next/blob/main/CONTRIBUTING.md) - [ ] Read the [Contributing Guidelines](https://github.com/skkuding/next/blob/main/CONTRIBUTING.md#pr-and-branch) and follow the [Commit Convention](https://github.com/skkuding/next/blob/main/CONTRIBUTING.md#commit-convention) - [ ] Provide a description in this PR that addresses **what** the PR is solving, or reference the issue that it solves (e.g. `fixes #123`). - [ ] Ideally, include relevant tests that fail without this PR but pass with it.
### Description <img width="566" height="209" alt="image" src="https://github.com/user-attachments/assets/a73bb1fb-249d-4e18-b547-2eb2fc65087b" /> 메인 배너 이미지가 깨지는 문제로 blur 처리하였습니다. 추가로 좌우 패딩 약간 조정하였습니다. ### Additional context <!-- e.g. is there anything you'd like reviewers to focus on? --> --- ### Before submitting the PR, please make sure you do the following - [ ] Read the [Contributing Guidelines](https://github.com/skkuding/next/blob/main/CONTRIBUTING.md) - [ ] Read the [Contributing Guidelines](https://github.com/skkuding/next/blob/main/CONTRIBUTING.md#pr-and-branch) and follow the [Commit Convention](https://github.com/skkuding/next/blob/main/CONTRIBUTING.md#commit-convention) - [ ] Provide a description in this PR that addresses **what** the PR is solving, or reference the issue that it solves (e.g. `fixes #123`). - [ ] Ideally, include relevant tests that fail without this PR but pass with it. closes TAS-2745 --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces layout and styling adjustments across the main page, banner, and Instagram cards, refactors the past course detection logic in CourseCard.tsx to use month-based markers, and updates the plagiarism check request logic to retrieve the first element as the latest request. Feedback points out a potential layout alignment issue in InstagramCards.tsx where removing mx-auto prevents centering on wide screens, and a potential race condition in PlagiarismCheckRequestButton.tsx where polling might immediately terminate with a cached completed status upon re-request.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
### Description 대회 전에 완성되지 않은 problem/create 경로에 대한 사용자 접근을 막습니다. <!-- Please insert your description here and provide especially info about the "what" this PR is solving --> ### Additional context 메인페이지의 문제 생성 바로가기 버튼을 숨김 처리 했습니다. closes TAS-2727 <!-- e.g. is there anything you'd like reviewers to focus on? --> --- ### Before submitting the PR, please make sure you do the following - [ ] Read the [Contributing Guidelines](https://github.com/skkuding/next/blob/main/CONTRIBUTING.md) - [ ] Read the [Contributing Guidelines](https://github.com/skkuding/next/blob/main/CONTRIBUTING.md#pr-and-branch) and follow the [Commit Convention](https://github.com/skkuding/next/blob/main/CONTRIBUTING.md#commit-convention) - [ ] Provide a description in this PR that addresses **what** the PR is solving, or reference the issue that it solves (e.g. `fixes #123`). - [ ] Ideally, include relevant tests that fail without this PR but pass with it.
### Description 1. 메인페이지 간격 조정했습니다! 창 좁혔을 때 어색하지 않은지 확인 부탁드립니다 2. 보민님 요청사항 - service card 아이콘 왼쪽->오른쪽 정렬로 변경했습니다! --- ### Before submitting the PR, please make sure you do the following - [ ] Read the [Contributing Guidelines](https://github.com/skkuding/next/blob/main/CONTRIBUTING.md) - [ ] Read the [Contributing Guidelines](https://github.com/skkuding/next/blob/main/CONTRIBUTING.md#pr-and-branch) and follow the [Commit Convention](https://github.com/skkuding/next/blob/main/CONTRIBUTING.md#commit-convention) - [ ] Provide a description in this PR that addresses **what** the PR is solving, or reference the issue that it solves (e.g. `fixes #123`). - [ ] Ideally, include relevant tests that fail without this PR but pass with it. closes TAS-2746
### Description #3617 에서 새로 생성된 요청이 폴링 쿼리에 반영되기 전, 최신 요청이 completed인 경우 요청 성공 여부에 관계없이 완료 메세지가 나오게 되므로, 생성 요청을 id 기반으로 추적하도록 수정합니다. ### Additional context <!-- e.g. is there anything you'd like reviewers to focus on? --> --- ### Before submitting the PR, please make sure you do the following - [ ] Read the [Contributing Guidelines](https://github.com/skkuding/next/blob/main/CONTRIBUTING.md) - [ ] Read the [Contributing Guidelines](https://github.com/skkuding/next/blob/main/CONTRIBUTING.md#pr-and-branch) and follow the [Commit Convention](https://github.com/skkuding/next/blob/main/CONTRIBUTING.md#commit-convention) - [ ] Provide a description in this PR that addresses **what** the PR is solving, or reference the issue that it solves (e.g. `fixes #123`). - [ ] Ideally, include relevant tests that fail without this PR but pass with it. --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
@gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces layout and styling adjustments across several main page components (such as banners and cards), refactors the course expiration logic in CourseCard.tsx using a simplified month-based configuration, and improves plagiarism check tracking in PlagiarismCheckRequestButton.tsx by targeting a specific request ID. The review feedback highlights two important improvements: first, ensuring that polling in the plagiarism check only starts if a valid request ID is returned to prevent unnecessary timeouts; second, enhancing type safety in CourseCard.tsx by replacing the direct type assertion of the semester term with a proper type guard.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
3 participants
Description
교수님 요청사항에 대한 핫픽스 작업 및 메인페이지 배너 수정입니다.
Additional context
Before submitting the PR, please make sure you do the following
fixes #123).