Skip to content

fix(fe): track latest plag request with id#3619

Merged
hjkim24 merged 4 commits into
mainfrom
hotfix-track-latest-request-for-plagiarism-with-id
Jun 11, 2026
Merged

fix(fe): track latest plag request with id#3619
hjkim24 merged 4 commits into
mainfrom
hotfix-track-latest-request-for-plagiarism-with-id

Conversation

@hjkim24

@hjkim24 hjkim24 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Description

#3617 에서 새로 생성된 요청이 폴링 쿼리에 반영되기 전, 최신 요청이 completed인 경우 요청 성공 여부에 관계없이 완료 메세지가 나오게 되므로, 생성 요청을 id 기반으로 추적하도록 수정합니다.

Additional context


Before submitting the PR, please make sure you do the following

@hjkim24 hjkim24 self-assigned this Jun 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a race condition guard in the plagiarism check polling mechanism by tracking the specific check request ID created by the current trigger, rather than simply tracking the latest request. Feedback was provided regarding a TypeScript type mismatch where the currentCheckId state is defined as string | null but should be number | null to match the GraphQL schema's Int type for the id field, preventing potential compilation and comparison errors.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

hjkim24 and others added 2 commits June 11, 2026 23:12
…ntId]/(overall)/@tabs/plagiarism/_components/PlagiarismCheckRequestButton.tsx

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

@seoeun9 seoeun9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!!
주석은 머지 전에 지워주세요!

Removed comments regarding the tracking of check requests and polling behavior.
@hjkim24 hjkim24 enabled auto-merge June 11, 2026 16:24
@hjkim24 hjkim24 added this pull request to the merge queue Jun 11, 2026
Merged via the queue into main with commit 514d07b Jun 11, 2026
18 checks passed
@hjkim24 hjkim24 deleted the hotfix-track-latest-request-for-plagiarism-with-id branch June 11, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants