Skip to content

Updated label used by expose-pods-by-name test#2520

Open
fgiorgetti wants to merge 1 commit into
skupperproject:mainfrom
fgiorgetti:expose-pods-by-name-fix
Open

Updated label used by expose-pods-by-name test#2520
fgiorgetti wants to merge 1 commit into
skupperproject:mainfrom
fgiorgetti:expose-pods-by-name-fix

Conversation

@fgiorgetti

@fgiorgetti fgiorgetti commented Jul 3, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Tests
    • Updated an end-to-end scenario to more accurately detect exposed services, improving reliability of pod-to-service name checks before and after deployment restarts.

@fgiorgetti fgiorgetti requested review from granzoto and removed request for c-kruse and nluaces July 3, 2026 15:06
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bea99874-1b85-40c3-88a9-fbb434ef77d0

📥 Commits

Reviewing files that changed from the base of the PR and between 143bc97 and 3a142af.

📒 Files selected for processing (1)
  • tests/e2e/scenarios/expose-pods-by-name/test.yml

📝 Walkthrough

Walkthrough

Modified an Ansible e2e test scenario file to change the label selector filter used for discovering Skupper-exposed Services/Listeners, updating internal.skupper.io/listener matching from true to backend in two locations.

Changes

Label Selector Update

Layer / File(s) Summary
Update listener label selector
tests/e2e/scenarios/expose-pods-by-name/test.yml
Changed kubernetes.core.k8s_info label_selectors filter for internal.skupper.io/listener from true to backend in both the initial and post-restart service discovery steps, affecting which services are collected for pod-vs-service name comparisons.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating the label used by the expose-pods-by-name test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fgiorgetti fgiorgetti requested a review from hash-d July 3, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant