fix: update pyproject.toml and requirements.txt with required fields#49
Conversation
There was a problem hiding this comment.
🪓 question: Should we prefer pyproject.toml overall? IIRC requirements.txt isn't recommended going forward but no blocker here!
There was a problem hiding this comment.
Yea, I think so. In future iterations, let's start only including pyproject.toml.
| [tool.setuptools.packages.find] | ||
| include = ["agent*", "listeners*"] |
There was a problem hiding this comment.
👁️🗨️ praise: This might be difficult to maintain onward but perhaps we revisit sample structure later?
There was a problem hiding this comment.
Yea, I wonder if we should start to store everything in src/?
| dependencies = [ | ||
| "slack-sdk==3.40.0", | ||
| "slack-bolt==1.27.0", | ||
| "slack-cli-hooks<1.0.0", |
There was a problem hiding this comment.
🔭 question: I'm alright keeping this as a required dependency, but would we want to move this to optional? I'm also still a believer in pinned version FWIW-
There was a problem hiding this comment.
Sure, let's move it to optional in the future
|
Thanks for the review and great ideas! Let's incorporate these in the future iterations of the Sample Apps! |
Type of change
Summary
This pull request updated
pyproject.tomlandrequirements.txtwith the following:pip install -e .error by adding the required[tool.setuptools.packages.find]fields topyproject.tomlpyproject.tomlwith the name, version, and minimum Python version fieldspyproject.tomlwith the dependencies for developers who prefer to usepyproject.tomlinstead ofrequirementst.txtslack-cli-hooks<1.0.0to bothrequirements.txtandpyproject.tomlbecause we're starting to include this dependency in sample appsTest Steps
Requirements