feat: add authorship arguments to say_stream#1502
Conversation
The SDK now includes icon_emoji, icon_url, and username in ChatStream._stream_args. Update assertions to expect these keys. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Add icon_emoji, icon_url, and username parameters to say_stream() call, matching the new authorship support in slack_sdk v3.42.0. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1502 +/- ##
=======================================
Coverage 91.30% 91.30%
=======================================
Files 228 228
Lines 7271 7271
=======================================
Hits 6639 6639
Misses 632 632 ☔ View full report in Codecov by Sentry. |
Add icon_emoji, icon_url, and username parameters to set_status(), matching the new authorship support in slack_sdk v3.42.0. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
|
⚡ Similar changes might not be needed in Bolt JS with the subtracted arguments: |
WilliamBergamin
left a comment
There was a problem hiding this comment.
This looks good 💯
I think I overlooked the assert statements in the original contribution for this, asserting against internal fields can lead to issues, we don't want this to become a pattern in the project 😅
We might want to set up a "mock server" make a request to it using say_stream and capture the arguments 🤔 there might also be a simpler way to do this as well
| "task_display_mode": None, | ||
| "icon_emoji": None, | ||
| "icon_url": None, | ||
| "username": None, |
There was a problem hiding this comment.
I think I overlooked how these asserts are expecting internal arguments, if you find a better solution to please contribute it 🙏 We don't want this to become a pattern in the project 😅
There was a problem hiding this comment.
We might need to set up a mock web server and capture the request sent to it 🤔
There was a problem hiding this comment.
@WilliamBergamin I'll hold off on merging this to find these preferred patterns! Super appreciate the second thought toward this 🧠 💡
Summary
This PR adds
icon_emoji,icon_url, andusernameauthorship arguments toSayStream,AsyncSayStream,SetStatus, andAsyncSetStatushelpers to match the new authorship support added inslack_sdkv3.42.0 🚀Testing
Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsRequirements
./scripts/install_all_and_run_tests.shafter making the changes.