Provide a way to enable / disable cache of property names when building the config #1434
+109
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radcortez
force-pushed
the
cache-property-names-in-builder
branch
from
afde15f to
4b47ed5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cache the list of property names because they are expensive to calculate on every call to
org.eclipse.microprofile.config.Config#getPropertyNames(the spec, leaves that open to the implementation).Now, because in Quarkus, we mutate configuration during tests, we cannot cache the list of names, so we need to call
io.smallrye.config.SmallRyeConfig#getLatestPropertyNames.With this PR, we can disable the caching for the test config and rely solely on
getPropertyNames.