Add OrgId to confidential relay and workflow execution types#1975
Add OrgId to confidential relay and workflow execution types#1975
Conversation
Bump chainlink-protos to cre-sdk/v1alpha.20 which adds org_id to the WorkflowExecution proto. Add OrgID to the confidential relay SecretsRequestParams so the enclave can forward it to VaultDON for org-based secret ownership.
|
👋 nadahalli, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
✅ API Diff Results -
|
There was a problem hiding this comment.
Pull request overview
Updates confidential workflow and relay request types to carry organization identity through to the enclave/VaultDON secrets path by bumping the relevant protos and regenerating code.
Changes:
- Bump
chainlink-protos/cre/godependency to a version that includesorg_idonWorkflowExecution. - Regenerate confidential workflow protobuf Go bindings to add
OrgId+ accessor onWorkflowExecution. - Add
OrgIDtoconfidentialrelay.SecretsRequestParamsfor JSON-RPC calls.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/capabilities/v2/actions/confidentialworkflow/client.pb.go | Regenerated protobuf bindings adding org_id to WorkflowExecution. |
| pkg/capabilities/v2/actions/confidentialrelay/types.go | Extends secrets JSON-RPC params with optional org_id. |
| go.mod | Bumps chainlink-protos/cre/go to a newer pseudo-version containing the updated proto. |
| go.sum | Updates sums for the bumped chainlink-protos/cre/go version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ExecutionId string `protobuf:"bytes,6,opt,name=execution_id,json=executionId,proto3" json:"execution_id,omitempty"` | ||
| // org_id is the organization identifier for the workflow owner. | ||
| // Used by the enclave when fetching secrets from VaultDON with org-based ownership. | ||
| OrgId string `protobuf:"bytes,7,opt,name=org_id,json=orgId,proto3" json:"org_id,omitempty"` |
There was a problem hiding this comment.
The newly added OrgId field line appears to have non-gofmt spacing (OrgId string ...) compared to the rest of the struct. If CI enforces gofmt/gofumpt, this will fail lint. Re-run the proto/codegen step and/or gofmt on this file to normalize whitespace.
| OrgId string `protobuf:"bytes,7,opt,name=org_id,json=orgId,proto3" json:"org_id,omitempty"` | |
| OrgId string `protobuf:"bytes,7,opt,name=org_id,json=orgId,proto3" json:"org_id,omitempty"` |
Summary
cre-sdk/v1alpha.20(addsorg_idfield toWorkflowExecutionproto)confidentialworkflowcodegen (client.pb.go)OrgIDtoconfidentialrelay.SecretsRequestParamsThe enclave needs org identity to forward to VaultDON when fetching secrets via the confidential relay path, matching the existing org-based ownership pattern in executor.go.
Waterfall: chainlink-protos#338 (merged) -> this -> chainlink (cw-4) + CC (PR 279)