Skip to content

Doc: fix utils.WithJitter Deprecation notice#2012

Merged
jmank88 merged 3 commits into
mainfrom
doc/deprectated-WithJitter-go-fix-inline
Jun 11, 2026
Merged

Doc: fix utils.WithJitter Deprecation notice#2012
jmank88 merged 3 commits into
mainfrom
doc/deprectated-WithJitter-go-fix-inline

Conversation

@patricios-space

Copy link
Copy Markdown
Contributor

🥜 Update utils.WithJitter's deprecation notice so that linter picks up it is deprecated, with quick autofix for replacing it with timeutil.JitterPct. See https://go.dev/wiki/Deprecated .

In a snippet like this:

utils.WithJitter(duration)

go:fix replaces it with

timeutil.JitterPct(0.1).Apply(duration)

@patricios-space patricios-space force-pushed the doc/deprectated-WithJitter-go-fix-inline branch from efb84d8 to 075a97e Compare April 29, 2026 18:21
@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown

📊 API Diff Results

No changes detected for module github.com/smartcontractkit/chainlink-common

View full report

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the deprecation guidance for utils.WithJitter so Go tooling/lint can recognize it as deprecated and offer an automated rewrite toward timeutil.JitterPct.

Changes:

  • Refined WithJitter’s Deprecated: doc comment to point to the intended replacement usage.
  • Added a //go:fix inline directive to enable automatic inlining/rewrite of call sites.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/utils/utils.go Outdated
@patricios-space patricios-space marked this pull request as ready for review April 29, 2026 22:04
@patricios-space patricios-space requested a review from a team as a code owner April 29, 2026 22:04
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open 30 days with no activity.
Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale label May 30, 2026
@jmank88 jmank88 added this pull request to the merge queue Jun 11, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 11, 2026
@jmank88 jmank88 added this pull request to the merge queue Jun 11, 2026
Merged via the queue into main with commit 1198ec6 Jun 11, 2026
30 of 33 checks passed
@jmank88 jmank88 deleted the doc/deprectated-WithJitter-go-fix-inline branch June 11, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants