Wire Telemetry metric views config to Beholder and LOOP plugins

.changeset/beholder-metric-views-deny-attributes.md

@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+#added Add `Telemetry.MetricViewsDenyAttributes` config option to drop specified metric attribute keys from Beholder default views.

core/cmd/shell.go

@@ -172,8 +172,9 @@ func newBeholderClient(
 		LogMaxQueueSize:                cfgTelemetry.LogMaxQueueSize(),
 		// Due to OpenTelemetry semantics, histogram bucket boundaries must be set
 		// when the Beholder client is constructed.
-		MetricViews:            metricViews(),
-		MetricCardinalityLimit: cfgTelemetry.MetricCardinalityLimit(),
+		MetricViews:               metricViews(),
+		MetricViewsDenyAttributes: cfgTelemetry.MetricViewsDenyAttributes(),
+		MetricCardinalityLimit:    cfgTelemetry.MetricCardinalityLimit(),
 	}
 
 	if cfgTracing.Enabled() {

core/config/docs/core.toml

@@ -928,6 +928,9 @@ LogExportMaxBatchSize = 512 # Default
 LogExportInterval = '1s' # Default
 # LogMaxQueueSize sets the maximum queue size used by the batcher
 LogMaxQueueSize = 2048 # Default
+# MetricViewsDenyAttributes lists attribute keys dropped before export (e.g. event_id).
+# Empty disables default Beholder metric attribute deny views.
+MetricViewsDenyAttributes = ['event_id'] # Default
 # MetricCardinalityLimit sets the OTel SDK per-instrument attribute-set limit (0 disables).
 MetricCardinalityLimit = 100000 # Default
 

core/config/telemetry_config.go

@@ -38,6 +38,7 @@ type Telemetry interface {
 	LogExportMaxBatchSize() int
 	LogExportInterval() time.Duration
 	LogMaxQueueSize() int
+	MetricViewsDenyAttributes() []string
 	MetricCardinalityLimit() int
 	PrometheusBridge() PrometheusBridge
 }

core/config/toml/types.go

@@ -3002,13 +3002,13 @@
 	LogExportMaxBatchSize              *int
 	LogExportInterval                  *commonconfig.Duration
 	LogMaxQueueSize                    *int
-
-	MetricCardinalityLimit *int
+	MetricViewsDenyAttributes          []string
+	MetricCardinalityLimit             *int
 
 	PrometheusBridge PrometheusBridge `toml:",omitempty"`
 }
 
 func (b *Telemetry) setFrom(f *Telemetry) {
 	if v := f.Enabled; v != nil {
 		b.Enabled = v
 	}
@@ -3102,6 +3102,9 @@
 	if v := f.LogMaxQueueSize; v != nil {
 		b.LogMaxQueueSize = v
 	}
+	if v := f.MetricViewsDenyAttributes; v != nil {
+		b.MetricViewsDenyAttributes = v
+	}
 	if v := f.MetricCardinalityLimit; v != nil {
 		b.MetricCardinalityLimit = v
 	}

core/services/chainlink/config_telemetry.go

@@ -263,7 +263,14 @@ func (b *telemetryConfig) LogMaxQueueSize() int {
 	return *b.s.LogMaxQueueSize
 }
 
+func (b *telemetryConfig) MetricViewsDenyAttributes() []string {
+	return b.s.MetricViewsDenyAttributes
+}
+
 func (b *telemetryConfig) MetricCardinalityLimit() int {
+	if b.s.MetricCardinalityLimit == nil {
+		return 100000
+	}
 	return *b.s.MetricCardinalityLimit
 }
 

core/services/chainlink/config_telemetry_test.go

@@ -553,6 +553,27 @@ func TestTelemetryConfig_LogMaxQueueSize(t *testing.T) {
 	}
 }
 
+func TestTelemetryConfig_MetricViewsDenyAttributes(t *testing.T) {
+	t.Parallel()
+	tests := []struct {
+		name      string
+		telemetry toml.Telemetry
+		expected  []string
+	}{
+		{"DenylistSet", toml.Telemetry{MetricViewsDenyAttributes: []string{"event_id"}}, []string{"event_id"}},
+		{"DenylistNil", toml.Telemetry{MetricViewsDenyAttributes: nil}, nil},
+		{"DenylistEmpty", toml.Telemetry{MetricViewsDenyAttributes: []string{}}, []string{}},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+			tc := telemetryConfig{s: tt.telemetry}
+			assert.Equal(t, tt.expected, tc.MetricViewsDenyAttributes())
+		})
+	}
+}
+
 func TestTelemetryConfig_MetricCardinalityLimit(t *testing.T) {
 	t.Parallel()
 	tests := []struct {

core/services/chainlink/config_test.go

@@ -582,6 +582,7 @@ func TestConfig_Marshal(t *testing.T) {
 		LogExportMaxBatchSize:              new(512),
 		LogExportInterval:                  ptrDuration(1 * time.Second),
 		LogMaxQueueSize:                    new(2048),
+		MetricViewsDenyAttributes:          []string{"event_id"},
 		MetricCardinalityLimit:             new(100000),
 
 		PrometheusBridge: toml.PrometheusBridge{

core/services/chainlink/testdata/config-empty-effective.toml

@@ -369,6 +369,7 @@ LogExportTimeout = '1s'
 LogExportMaxBatchSize = 512
 LogExportInterval = '1s'
 LogMaxQueueSize = 2048
+MetricViewsDenyAttributes = ['event_id']
 MetricCardinalityLimit = 100000
 
 [Telemetry.PrometheusBridge]

core/services/chainlink/testdata/config-full.toml

@@ -404,6 +404,7 @@ LogExportTimeout = '1s'
 LogExportMaxBatchSize = 512
 LogExportInterval = '1s'
 LogMaxQueueSize = 2048
+MetricViewsDenyAttributes = ['event_id']
 MetricCardinalityLimit = 100000
 
 [Telemetry.ResourceAttributes]

core/services/chainlink/testdata/config-multi-chain-effective.toml

@@ -369,6 +369,7 @@ LogExportTimeout = '1s'
 LogExportMaxBatchSize = 512
 LogExportInterval = '1s'
 LogMaxQueueSize = 2048
+MetricViewsDenyAttributes = ['event_id']
 MetricCardinalityLimit = 100000
 
 [Telemetry.PrometheusBridge]

core/web/resolver/testdata/config-empty-effective.toml

@@ -369,6 +369,7 @@ LogExportTimeout = '1s'
 LogExportMaxBatchSize = 512
 LogExportInterval = '1s'
 LogMaxQueueSize = 2048
+MetricViewsDenyAttributes = ['event_id']
 MetricCardinalityLimit = 100000
 
 [Telemetry.PrometheusBridge]

core/web/resolver/testdata/config-full.toml

@@ -383,6 +383,7 @@ LogExportTimeout = '1s'
 LogExportMaxBatchSize = 512
 LogExportInterval = '1s'
 LogMaxQueueSize = 2048
+MetricViewsDenyAttributes = ['event_id']
 MetricCardinalityLimit = 100000
 
 [Telemetry.ResourceAttributes]

core/web/resolver/testdata/config-multi-chain-effective.toml

@@ -369,6 +369,7 @@ LogExportTimeout = '1s'
 LogExportMaxBatchSize = 512
 LogExportInterval = '1s'
 LogMaxQueueSize = 2048
+MetricViewsDenyAttributes = ['event_id']
 MetricCardinalityLimit = 100000
 
 [Telemetry.PrometheusBridge]

docs/CONFIG.md

@@ -2412,6 +2412,7 @@ LogExportTimeout = '1s' # Default
 LogExportMaxBatchSize = 512 # Default
 LogExportInterval = '1s' # Default
 LogMaxQueueSize = 2048 # Default
+MetricViewsDenyAttributes = ['event_id'] # Default
 MetricCardinalityLimit = 100000 # Default
 ```
 Telemetry holds OTEL settings.
@@ -2603,6 +2604,13 @@ LogMaxQueueSize = 2048 # Default
 ```
 LogMaxQueueSize sets the maximum queue size used by the batcher
 
+### MetricViewsDenyAttributes
+```toml
+MetricViewsDenyAttributes = ['event_id'] # Default
+```
+MetricViewsDenyAttributes lists attribute keys dropped before export (e.g. event_id).
+Empty disables default Beholder metric attribute deny views.
+
 ### MetricCardinalityLimit
 ```toml
 MetricCardinalityLimit = 100000 # Default

plugins/loop_registry.go

@@ -170,6 +170,7 @@ func (m *LoopRegistry) Register(id string) (*RegisteredLoop, error) {
 		envCfg.TelemetryLogExportMaxBatchSize = m.cfgTelemetry.LogExportMaxBatchSize()
 		envCfg.TelemetryLogExportInterval = m.cfgTelemetry.LogExportInterval()
 		envCfg.TelemetryLogMaxQueueSize = m.cfgTelemetry.LogMaxQueueSize()
+		envCfg.TelemetryMetricViewsDenyAttributes = m.cfgTelemetry.MetricViewsDenyAttributes()
 		limit := m.cfgTelemetry.MetricCardinalityLimit()
 		envCfg.TelemetryMetricCardinalityLimit = &limit
 		envCfg.TelemetryPrometheusBridgeEnabled = m.cfgTelemetry.PrometheusBridge().Enabled()

plugins/loop_registry_test.go

@@ -108,6 +108,9 @@ func (m mockCfgTelemetry) LogExportMaxBatchSize() int       { return 512 }
 func (m mockCfgTelemetry) LogExportInterval() time.Duration { return 5 * time.Second }
 func (m mockCfgTelemetry) LogMaxQueueSize() int             { return 2048 }
 
+func (m mockCfgTelemetry) MetricViewsDenyAttributes() []string {
+	return []string{"event_id"}
+}
 func (m mockCfgTelemetry) MetricCardinalityLimit() int { return 100000 }
 
 func (m mockCfgTelemetry) PrometheusBridge() config.PrometheusBridge {
@@ -272,6 +275,7 @@ func TestLoopRegistry_Register(t *testing.T) {
 	require.Equal(t, 512, envCfg.TelemetryLogExportMaxBatchSize)
 	require.Equal(t, 5*time.Second, envCfg.TelemetryLogExportInterval)
 	require.Equal(t, 2048, envCfg.TelemetryLogMaxQueueSize)
+	require.Equal(t, []string{"event_id"}, envCfg.TelemetryMetricViewsDenyAttributes)
 	require.NotNil(t, envCfg.TelemetryMetricCardinalityLimit)
 	require.Equal(t, 100000, *envCfg.TelemetryMetricCardinalityLimit)
 

testdata/scripts/config/merge_raw_configs.txtar

@@ -516,6 +516,7 @@ LogExportTimeout = '1s'
 LogExportMaxBatchSize = 512
 LogExportInterval = '1s'
 LogMaxQueueSize = 2048
+MetricViewsDenyAttributes = ['event_id']
 MetricCardinalityLimit = 100000
 
 [Telemetry.PrometheusBridge]

testdata/scripts/node/validate/default.txtar

@@ -381,6 +381,7 @@ LogExportTimeout = '1s'
 LogExportMaxBatchSize = 512
 LogExportInterval = '1s'
 LogMaxQueueSize = 2048
+MetricViewsDenyAttributes = ['event_id']
 MetricCardinalityLimit = 100000
 
 [Telemetry.PrometheusBridge]

testdata/scripts/node/validate/defaults-override.txtar

@@ -442,6 +442,7 @@ LogExportTimeout = '1s'
 LogExportMaxBatchSize = 512
 LogExportInterval = '1s'
 LogMaxQueueSize = 2048
+MetricViewsDenyAttributes = ['event_id']
 MetricCardinalityLimit = 100000
 
 [Telemetry.PrometheusBridge]

testdata/scripts/node/validate/disk-based-logging-disabled.txtar

@@ -425,6 +425,7 @@ LogExportTimeout = '1s'
 LogExportMaxBatchSize = 512
 LogExportInterval = '1s'
 LogMaxQueueSize = 2048
+MetricViewsDenyAttributes = ['event_id']
 MetricCardinalityLimit = 100000
 
 [Telemetry.PrometheusBridge]

testdata/scripts/node/validate/disk-based-logging-no-dir.txtar

@@ -425,6 +425,7 @@ LogExportTimeout = '1s'
 LogExportMaxBatchSize = 512
 LogExportInterval = '1s'
 LogMaxQueueSize = 2048
+MetricViewsDenyAttributes = ['event_id']
 MetricCardinalityLimit = 100000
 
 [Telemetry.PrometheusBridge]

testdata/scripts/node/validate/disk-based-logging.txtar

@@ -425,6 +425,7 @@ LogExportTimeout = '1s'
 LogExportMaxBatchSize = 512
 LogExportInterval = '1s'
 LogMaxQueueSize = 2048
+MetricViewsDenyAttributes = ['event_id']
 MetricCardinalityLimit = 100000
 
 [Telemetry.PrometheusBridge]

testdata/scripts/node/validate/fallback-override.txtar

@@ -527,6 +527,7 @@ LogExportTimeout = '1s'
 LogExportMaxBatchSize = 512
 LogExportInterval = '1s'
 LogMaxQueueSize = 2048
+MetricViewsDenyAttributes = ['event_id']
 MetricCardinalityLimit = 100000
 
 [Telemetry.PrometheusBridge]

testdata/scripts/node/validate/invalid-ocr-p2p.txtar

@@ -410,6 +410,7 @@ LogExportTimeout = '1s'
 LogExportMaxBatchSize = 512
 LogExportInterval = '1s'
 LogMaxQueueSize = 2048
+MetricViewsDenyAttributes = ['event_id']
 MetricCardinalityLimit = 100000
 
 [Telemetry.PrometheusBridge]

testdata/scripts/node/validate/invalid.txtar

@@ -421,6 +421,7 @@ LogExportTimeout = '1s'
 LogExportMaxBatchSize = 512
 LogExportInterval = '1s'
 LogMaxQueueSize = 2048
+MetricViewsDenyAttributes = ['event_id']
 MetricCardinalityLimit = 100000
 
 [Telemetry.PrometheusBridge]

testdata/scripts/node/validate/valid.txtar

@@ -422,6 +422,7 @@ LogExportTimeout = '1s'
 LogExportMaxBatchSize = 512
 LogExportInterval = '1s'
 LogMaxQueueSize = 2048
+MetricViewsDenyAttributes = ['event_id']
 MetricCardinalityLimit = 100000
 
 [Telemetry.PrometheusBridge]

testdata/scripts/node/validate/warnings.txtar

@@ -404,6 +404,7 @@ LogExportTimeout = '1s'
 LogExportMaxBatchSize = 512
 LogExportInterval = '1s'
 LogMaxQueueSize = 2048
+MetricViewsDenyAttributes = ['event_id']
 MetricCardinalityLimit = 100000
 
 [Telemetry.PrometheusBridge]