Skip to content
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions core/services/standardcapabilities/standard_capabilities.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@

wg sync.WaitGroup
readyChan chan struct{}
readyErr error
stopChan services.StopChan
startTimeout time.Duration
}
Expand Down Expand Up @@ -114,6 +115,7 @@

if err = s.capabilitiesLoop.WaitCtx(cctx); err != nil {
s.log.Errorf("error waiting for standard capabilities service to start: %v", err)
s.readyErr = fmt.Errorf("error waiting for standard capabilities service to start: %w", err)
return
}

Expand All @@ -132,13 +134,15 @@
}
if err = s.capabilitiesLoop.Service.Initialise(cctx, dependencies); err != nil {
s.log.Errorf("error initialising standard capabilities service: %v", err)
s.readyErr = ...

Check failure on line 137 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_tests_integration)

syntax error: unexpected ..., expected expression

Check failure on line 137 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_tests_integration)

syntax error: unexpected ..., expected expression

Check failure on line 137 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Analyze (go)

syntax error: unexpected ..., expected expression

Check failure on line 137 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_tests)

syntax error: unexpected ..., expected expression

Check failure on line 137 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_tests)

syntax error: unexpected ..., expected expression

Check failure on line 137 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_tests)

syntax error: unexpected ..., expected expression

Check failure on line 137 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_race_tests)

syntax error: unexpected ..., expected expression

Check failure on line 137 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_race_tests)

syntax error: unexpected ..., expected expression

Check failure on line 137 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_race_tests)

syntax error: unexpected ..., expected expression

Check failure on line 137 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_fuzz)

syntax error: unexpected ..., expected expression

Check warning on line 137 in core/services/standardcapabilities/standard_capabilities.go

View check run for this annotation

CL-sonarqube-production / SonarQube Code Analysis

expected operand, found '...'

[typecheck.bug.major] Issue raised by typecheck See more on https://sonarqube.main.prod.cldev.sh/project/issues?id=smartcontractkit_chainlink&pullRequest=23202&issues=f1351d0d-37c8-411b-bb1c-bee04eb05b91&open=f1351d0d-37c8-411b-bb1c-bee04eb05b91
return

Check failure on line 138 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_tests_integration)

syntax error: unexpected keyword return at end of statement

Check failure on line 138 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_tests_integration)

syntax error: unexpected keyword return at end of statement

Check failure on line 138 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Analyze (go)

syntax error: unexpected keyword return at end of statement

Check failure on line 138 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_tests)

syntax error: unexpected keyword return at end of statement

Check failure on line 138 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_tests)

syntax error: unexpected keyword return at end of statement

Check failure on line 138 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_tests)

syntax error: unexpected keyword return at end of statement

Check failure on line 138 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_race_tests)

syntax error: unexpected keyword return at end of statement

Check failure on line 138 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_race_tests)

syntax error: unexpected keyword return at end of statement

Check failure on line 138 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_race_tests)

syntax error: unexpected keyword return at end of statement

Check failure on line 138 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_fuzz)

syntax error: unexpected keyword return at end of statement
}

capabilityInfos, err := s.capabilitiesLoop.Service.Infos(cctx)
if err != nil {
s.log.Errorf("error getting standard capabilities service info: %v", err)
s.readyErr = ...

Check failure on line 144 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_tests_integration)

syntax error: unexpected ..., expected expression

Check failure on line 144 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_tests_integration)

syntax error: unexpected ..., expected expression

Check failure on line 144 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Analyze (go)

syntax error: unexpected ..., expected expression

Check failure on line 144 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_tests)

syntax error: unexpected ..., expected expression

Check failure on line 144 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_tests)

syntax error: unexpected ..., expected expression

Check failure on line 144 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_race_tests)

syntax error: unexpected ..., expected expression

Check failure on line 144 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_race_tests)

syntax error: unexpected ..., expected expression

Check failure on line 144 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_fuzz)

syntax error: unexpected ..., expected expression

Check warning on line 144 in core/services/standardcapabilities/standard_capabilities.go

View check run for this annotation

CL-sonarqube-production / SonarQube Code Analysis

expected operand, found '...'

[typecheck.bug.major] Issue raised by typecheck See more on https://sonarqube.main.prod.cldev.sh/project/issues?id=smartcontractkit_chainlink&pullRequest=23202&issues=e93d52b0-015e-4b5e-b039-3d7c2f650d19&open=e93d52b0-015e-4b5e-b039-3d7c2f650d19
return

Check failure on line 145 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_tests_integration)

syntax error: unexpected keyword return at end of statement

Check failure on line 145 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_tests_integration)

syntax error: unexpected keyword return at end of statement

Check failure on line 145 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Analyze (go)

syntax error: unexpected keyword return at end of statement

Check failure on line 145 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_tests)

syntax error: unexpected keyword return at end of statement

Check failure on line 145 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_tests)

syntax error: unexpected keyword return at end of statement

Check failure on line 145 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_race_tests)

syntax error: unexpected keyword return at end of statement

Check failure on line 145 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_race_tests)

syntax error: unexpected keyword return at end of statement

Check failure on line 145 in core/services/standardcapabilities/standard_capabilities.go

View workflow job for this annotation

GitHub Actions / Core Tests (go_core_fuzz)

syntax error: unexpected keyword return at end of statement
}

s.log.Info("Started standard capabilities", "command", s.command, "capabilities", capabilityInfos)
Expand All @@ -156,7 +160,7 @@
}
select {
case <-s.readyChan:
return nil
return s.readyErr
case <-s.stopChan:
return ErrServiceStopped
default:
Expand All @@ -168,7 +172,7 @@
func (s *StandardCapabilities) Await(ctx context.Context) error {
select {
case <-s.readyChan:
return nil
return s.readyErr
case <-s.stopChan:
return ErrServiceStopped
case <-ctx.Done():
Expand Down
Loading